You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/02/07 02:45:35 UTC
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1444: chore: Added a data global file
juzhiyuan commented on a change in pull request #1444:
URL: https://github.com/apache/apisix-dashboard/pull/1444#discussion_r571520050
##########
File path: web/cypress/fixtures/data.json
##########
@@ -0,0 +1,31 @@
+{
+ "deletePluginSuccess": "Delete Plugin Successfully",
+ "createUpstreamSuccess": "Create Upstream Successfully",
+ "createServiceSuccess": "Create Service Successfully",
+ "editServiceSuccess": "Edit Service Successfully",
+ "deleteServiceSuccess": "Delete Service Successfully",
+ "deleteRouteSuccess": "Delete Route Successfully",
+ "submitSuccess": "Submit Successfully",
+ "deleteUpstreamSuccess": "Delete Upstream Successfully",
+ "createConsumerSuccess": "Create Consumer Successfully",
+ "deleteConsumerSuccess": "Delete Consumer Successfully",
+ "upstreamName": "test_upstream",
+ "serviceName": "test_service",
+ "serviceName2": "test_service",
Review comment:
the value is the same as `serviceName`?
##########
File path: web/cypress/fixtures/data.json
##########
@@ -0,0 +1,31 @@
+{
+ "deletePluginSuccess": "Delete Plugin Successfully",
+ "createUpstreamSuccess": "Create Upstream Successfully",
+ "createServiceSuccess": "Create Service Successfully",
+ "editServiceSuccess": "Edit Service Successfully",
+ "deleteServiceSuccess": "Delete Service Successfully",
+ "deleteRouteSuccess": "Delete Route Successfully",
+ "submitSuccess": "Submit Successfully",
+ "deleteUpstreamSuccess": "Delete Upstream Successfully",
+ "createConsumerSuccess": "Create Consumer Successfully",
+ "deleteConsumerSuccess": "Delete Consumer Successfully",
+ "upstreamName": "test_upstream",
+ "serviceName": "test_service",
+ "serviceName2": "test_service",
+ "routeName": "test_route",
+ "consumerrName": "test_consumer",
Review comment:
```suggestion
"consumerName": "test_consumer",
```
##########
File path: web/cypress/fixtures/data.json
##########
@@ -0,0 +1,31 @@
+{
+ "deletePluginSuccess": "Delete Plugin Successfully",
+ "createUpstreamSuccess": "Create Upstream Successfully",
+ "createServiceSuccess": "Create Service Successfully",
+ "editServiceSuccess": "Edit Service Successfully",
+ "deleteServiceSuccess": "Delete Service Successfully",
+ "deleteRouteSuccess": "Delete Route Successfully",
+ "submitSuccess": "Submit Successfully",
+ "deleteUpstreamSuccess": "Delete Upstream Successfully",
+ "createConsumerSuccess": "Create Consumer Successfully",
+ "deleteConsumerSuccess": "Delete Consumer Successfully",
+ "upstreamName": "test_upstream",
+ "serviceName": "test_service",
+ "serviceName2": "test_service",
+ "routeName": "test_route",
+ "consumerrName": "test_consumer",
+ "ip1": "127.0.0.1",
+ "ip2": "127.0.0.2",
+ "host1": "11.11.11.11",
+ "host2": "12.12.12.12",
+ "host3": "10.10.10.10",
+ "description": "desc_by_autotes",
Review comment:
```suggestion
"description": "desc_by_autotest",
```
##########
File path: web/cypress/fixtures/data.json
##########
@@ -0,0 +1,31 @@
+{
+ "deletePluginSuccess": "Delete Plugin Successfully",
+ "createUpstreamSuccess": "Create Upstream Successfully",
+ "createServiceSuccess": "Create Service Successfully",
+ "editServiceSuccess": "Edit Service Successfully",
+ "deleteServiceSuccess": "Delete Service Successfully",
+ "deleteRouteSuccess": "Delete Route Successfully",
+ "submitSuccess": "Submit Successfully",
+ "deleteUpstreamSuccess": "Delete Upstream Successfully",
+ "createConsumerSuccess": "Create Consumer Successfully",
+ "deleteConsumerSuccess": "Delete Consumer Successfully",
+ "upstreamName": "test_upstream",
+ "serviceName": "test_service",
+ "serviceName2": "test_service",
+ "routeName": "test_route",
+ "consumerrName": "test_consumer",
+ "ip1": "127.0.0.1",
+ "ip2": "127.0.0.2",
+ "host1": "11.11.11.11",
+ "host2": "12.12.12.12",
+ "host3": "10.10.10.10",
+ "description": "desc_by_autotes",
+ "description2": "new desc",
+ "grafanaAddress": "Grafana Address",
+ "grafanaExplanation1": "Grafana address should begin with HTTP or HTTPS",
+ "grafanaExplanation2": "Address is illegality",
+ "updateSuccessfully": "Update Configuration Successfully",
+ "sslRemoveSuccessfully": "Remove target SSL successfully",
Review comment:
`deleteSSLSuccess` keep the same as others.
##########
File path: web/cypress/fixtures/data.json
##########
@@ -0,0 +1,31 @@
+{
+ "deletePluginSuccess": "Delete Plugin Successfully",
+ "createUpstreamSuccess": "Create Upstream Successfully",
+ "createServiceSuccess": "Create Service Successfully",
+ "editServiceSuccess": "Edit Service Successfully",
+ "deleteServiceSuccess": "Delete Service Successfully",
+ "deleteRouteSuccess": "Delete Route Successfully",
+ "submitSuccess": "Submit Successfully",
+ "deleteUpstreamSuccess": "Delete Upstream Successfully",
+ "createConsumerSuccess": "Create Consumer Successfully",
+ "deleteConsumerSuccess": "Delete Consumer Successfully",
+ "upstreamName": "test_upstream",
+ "serviceName": "test_service",
+ "serviceName2": "test_service",
+ "routeName": "test_route",
+ "consumerrName": "test_consumer",
+ "ip1": "127.0.0.1",
+ "ip2": "127.0.0.2",
+ "host1": "11.11.11.11",
+ "host2": "12.12.12.12",
+ "host3": "10.10.10.10",
+ "description": "desc_by_autotes",
+ "description2": "new desc",
Review comment:
```suggestion
"description2": "description2",
```
##########
File path: web/cypress/fixtures/data.json
##########
@@ -0,0 +1,31 @@
+{
+ "deletePluginSuccess": "Delete Plugin Successfully",
+ "createUpstreamSuccess": "Create Upstream Successfully",
+ "createServiceSuccess": "Create Service Successfully",
+ "editServiceSuccess": "Edit Service Successfully",
+ "deleteServiceSuccess": "Delete Service Successfully",
+ "deleteRouteSuccess": "Delete Route Successfully",
+ "submitSuccess": "Submit Successfully",
+ "deleteUpstreamSuccess": "Delete Upstream Successfully",
+ "createConsumerSuccess": "Create Consumer Successfully",
+ "deleteConsumerSuccess": "Delete Consumer Successfully",
+ "upstreamName": "test_upstream",
+ "serviceName": "test_service",
+ "serviceName2": "test_service",
+ "routeName": "test_route",
+ "consumerrName": "test_consumer",
+ "ip1": "127.0.0.1",
+ "ip2": "127.0.0.2",
+ "host1": "11.11.11.11",
+ "host2": "12.12.12.12",
+ "host3": "10.10.10.10",
+ "description": "desc_by_autotes",
+ "description2": "new desc",
+ "grafanaAddress": "Grafana Address",
+ "grafanaExplanation1": "Grafana address should begin with HTTP or HTTPS",
+ "grafanaExplanation2": "Address is illegality",
Review comment:
```suggestion
"grafanaExplanation2": "Address is invalid",
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org