You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2020/12/24 21:19:23 UTC
[GitHub] [guacamole-server] mike-jumper opened a new pull request #319: GUACAMOLE-1241: Avoid double-free when building against FreeRDP development snapshot.
mike-jumper opened a new pull request #319:
URL: https://github.com/apache/guacamole-server/pull/319
Currently, the Docker image for guacd built from the `staging/1.3.0` branch produces the following double-free error:
```
...
guacd[24698]: INFO: Loading keymap "base"
guacd[24698]: INFO: Loading keymap "en-us-qwerty"
guacd[24698]: INFO: Connected to RDPDR 1.13 as client 0x0005
free(): double free detected in tcache 2
guacd[6]: INFO: Connection "$e6955582-c6f2-4912-a4bd-a3ffee002cd1" removed.
```
This is because the Docker image is built from Debian stable, and the version of FreeRDP currently packaged by Debian stable is not a FreeRDP release but rather a development snapshot ([commit 2693389](https://github.com/FreeRDP/FreeRDP/commit/2693389a103394e035edc2a01055ca2c9ccccb21)) from after 2.0.0-rc4 but before 2.0.0. In that span of time, the handling of memory within FreeRDP changed, and while the behavior of 2.0.0 and 2.0.0-rc4 are known, there is no way for Guacamole to know the behavior of an arbitrary commit _between_ those versions.
To correct this, these changes:
* Change the build warning regarding FreeRDP development snapshots to a fatal error, requiring the user to specify `--enable-allow-freerdp-snapshots` if they are _absolutely certain_ that using a development snapshot is OK.
* Switch over to the Debian "stable-backports" repository (which has a more recent version of the FreeRDP package that is cut from the 2.2.0 release).
🎄
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-server] necouchman merged pull request #319: GUACAMOLE-1241: Avoid double-free when building against FreeRDP development snapshot.
Posted by GitBox <gi...@apache.org>.
necouchman merged pull request #319:
URL: https://github.com/apache/guacamole-server/pull/319
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org