You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by lu...@apache.org on 2009/11/23 18:13:22 UTC
svn commit: r883417 -
/myfaces/core/trunk/api/src/main/java/javax/faces/component/UIViewRoot.java
Author: lu4242
Date: Mon Nov 23 17:13:21 2009
New Revision: 883417
URL: http://svn.apache.org/viewvc?rev=883417&view=rev
Log:
Revert change continue processing phase without take into account response of previous listeners, because the javadoc of UIViewRoot is clear about this behavior.
Modified:
myfaces/core/trunk/api/src/main/java/javax/faces/component/UIViewRoot.java
Modified: myfaces/core/trunk/api/src/main/java/javax/faces/component/UIViewRoot.java
URL: http://svn.apache.org/viewvc/myfaces/core/trunk/api/src/main/java/javax/faces/component/UIViewRoot.java?rev=883417&r1=883416&r2=883417&view=diff
==============================================================================
--- myfaces/core/trunk/api/src/main/java/javax/faces/component/UIViewRoot.java (original)
+++ myfaces/core/trunk/api/src/main/java/javax/faces/component/UIViewRoot.java Mon Nov 23 17:13:21 2009
@@ -1208,19 +1208,17 @@
*/
private boolean _process(FacesContext context, PhaseId phaseId, PhaseProcessor processor)
{
- // If context.renderResponse() or context.responseComplete has been called on any listener before phase,
- // the phase should continue. Note that after the phase has ended this conditions are checked by
- // the lifecycle, and you can always put that kind of code on after phase listener instead.
- notifyListeners(context, phaseId, getBeforePhaseListener(), true);
-
try
{
- if (processor != null)
+ if (!notifyListeners(context, phaseId, getBeforePhaseListener(), true))
{
- processor.process(context, this);
+ if (processor != null)
+ {
+ processor.process(context, this);
+ }
+
+ broadcastEvents(context, phaseId);
}
-
- broadcastEvents(context, phaseId);
}
finally
{