[GitHub] [kafka] jsancio commented on a diff in pull request #13345: KAFKA-13020; Implement reading Snapshot log append timestamp

["jsancio (via GitHub)" <gi...@apache.org>]

jsancio commented on code in PR #13345:
URL: https://github.com/apache/kafka/pull/13345#discussion_r1153540193


##########
raft/src/main/java/org/apache/kafka/raft/Batch.java:
##########
@@ -33,21 +33,24 @@
     private final int sizeInBytes;
     private final long lastOffset;
     private final List<T> records;
+    private final List<ControlRecord> controlRecords;

Review Comment:
   Yes. That is correct. A record batch has 1 or more control records; or 1 or more data records.  We enforce that in two ways. 1) the ctr for this type is private and 2) the static methods `data` and `control` check that the passed list of records have one or more records.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org