You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Jeff Trawick <tr...@gmail.com> on 2011/01/31 22:39:48 UTC
Re: svn commit: r1065748 - in /httpd/httpd/trunk: configure.in
modules/proxy/mod_proxy.c modules/proxy/mod_proxy.h modules/proxy/mod_proxy_balancer.c
modules/proxy/proxy_util.c
On Mon, Jan 31, 2011 at 3:28 PM, <ji...@apache.org> wrote:
> Author: jim
> Date: Mon Jan 31 20:28:52 2011
> New Revision: 1065748
>
> URL: http://svn.apache.org/viewvc?rev=1065748&view=rev
> Log:
> Move some "nice to be able to change" balancer stuff to shm
>
> Modified:
> httpd/httpd/trunk/configure.in
...
>
> Modified: httpd/httpd/trunk/configure.in
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/configure.in?rev=1065748&r1=1065747&r2=1065748&view=diff
> ==============================================================================
> --- httpd/httpd/trunk/configure.in (original)
> +++ httpd/httpd/trunk/configure.in Mon Jan 31 20:28:52 2011
> @@ -529,7 +529,7 @@ AC_ARG_ENABLE(maintainer-mode,APACHE_HEL
> [
> APR_ADDTO(CPPFLAGS, -DAP_DEBUG)
> if test "$GCC" = "yes"; then
> - APR_ADDTO(CFLAGS,[-Wall -Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -Wpointer-arith])
> + APR_ADDTO(CFLAGS,[-Wall -Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -Wpointer-arith -O0])
> AC_CACHE_CHECK([whether gcc accepts -Wdeclaration-after-statement], [ap_cv_cc_Wdas], [
> save_CFLAGS=$CFLAGS
> CFLAGS="$CFLAGS -Wdeclaration-after-statement"
an accidental commit, I hope
Re: svn commit: r1065748 - in /httpd/httpd/trunk: configure.in modules/proxy/mod_proxy.c modules/proxy/mod_proxy.h modules/proxy/mod_proxy_balancer.c modules/proxy/proxy_util.c
Posted by Jim Jagielski <ji...@jaguNET.com>.
On Jan 31, 2011, at 4:39 PM, Jeff Trawick wrote:
> On Mon, Jan 31, 2011 at 3:28 PM, <ji...@apache.org> wrote:
>> Author: jim
>> Date: Mon Jan 31 20:28:52 2011
>> New Revision: 1065748
>>
>> URL: http://svn.apache.org/viewvc?rev=1065748&view=rev
>> Log:
>> Move some "nice to be able to change" balancer stuff to shm
>>
>> Modified:
>> httpd/httpd/trunk/configure.in
> ...
>>
>> Modified: httpd/httpd/trunk/configure.in
>> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/configure.in?rev=1065748&r1=1065747&r2=1065748&view=diff
>> ==============================================================================
>> --- httpd/httpd/trunk/configure.in (original)
>> +++ httpd/httpd/trunk/configure.in Mon Jan 31 20:28:52 2011
>> @@ -529,7 +529,7 @@ AC_ARG_ENABLE(maintainer-mode,APACHE_HEL
>> [
>> APR_ADDTO(CPPFLAGS, -DAP_DEBUG)
>> if test "$GCC" = "yes"; then
>> - APR_ADDTO(CFLAGS,[-Wall -Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -Wpointer-arith])
>> + APR_ADDTO(CFLAGS,[-Wall -Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -Wpointer-arith -O0])
>> AC_CACHE_CHECK([whether gcc accepts -Wdeclaration-after-statement], [ap_cv_cc_Wdas], [
>> save_CFLAGS=$CFLAGS
>> CFLAGS="$CFLAGS -Wdeclaration-after-statement"
>
> an accidental commit, I hope
>
Yes... you will see that in later commits ;)
Re: svn commit: r1065748 - in /httpd/httpd/trunk: configure.in modules/proxy/mod_proxy.c
modules/proxy/mod_proxy.h modules/proxy/mod_proxy_balancer.c modules/proxy/proxy_util.c
Posted by "William A. Rowe Jr." <wr...@rowe-clan.net>.
On 1/31/2011 3:39 PM, Jeff Trawick wrote:
> On Mon, Jan 31, 2011 at 3:28 PM, <ji...@apache.org> wrote:
>> Author: jim
>> Date: Mon Jan 31 20:28:52 2011
>> New Revision: 1065748
>>
>> --- httpd/httpd/trunk/configure.in (original)
>> +++ httpd/httpd/trunk/configure.in Mon Jan 31 20:28:52 2011
>> @@ -529,7 +529,7 @@ AC_ARG_ENABLE(maintainer-mode,APACHE_HEL
>> [
>> APR_ADDTO(CPPFLAGS, -DAP_DEBUG)
>> if test "$GCC" = "yes"; then
>> - APR_ADDTO(CFLAGS,[-Wall -Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -Wpointer-arith])
>> + APR_ADDTO(CFLAGS,[-Wall -Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -Wpointer-arith -O0])
>> AC_CACHE_CHECK([whether gcc accepts -Wdeclaration-after-statement], [ap_cv_cc_Wdas], [
>> save_CFLAGS=$CFLAGS
>> CFLAGS="$CFLAGS -Wdeclaration-after-statement"
>
> an accidental commit, I hope
Hoping as well :)
Love the idea of the --debugging mode, that will be very helpful, but there
are far too many things the compiler can only detect with optimizations enabled,
and for maintainer mode, the optimized-yet-debuggable build is what we want.