You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by pr...@apache.org on 2005/10/20 19:08:38 UTC

svn commit: r326946 - /myfaces/tomahawk/trunk/src/java/org/apache/myfaces/component/html/util/ReducedHTMLParser.java

Author: prophecy
Date: Thu Oct 20 10:08:33 2005
New Revision: 326946

URL: http://svn.apache.org/viewcvs?rev=326946&view=rev
Log:
was mistaking <thead> for <head> tag, fixed

Modified:
    myfaces/tomahawk/trunk/src/java/org/apache/myfaces/component/html/util/ReducedHTMLParser.java

Modified: myfaces/tomahawk/trunk/src/java/org/apache/myfaces/component/html/util/ReducedHTMLParser.java
URL: http://svn.apache.org/viewcvs/myfaces/tomahawk/trunk/src/java/org/apache/myfaces/component/html/util/ReducedHTMLParser.java?rev=326946&r1=326945&r2=326946&view=diff
==============================================================================
--- myfaces/tomahawk/trunk/src/java/org/apache/myfaces/component/html/util/ReducedHTMLParser.java (original)
+++ myfaces/tomahawk/trunk/src/java/org/apache/myfaces/component/html/util/ReducedHTMLParser.java Thu Oct 20 10:08:33 2005
@@ -126,6 +126,7 @@
 
                 }
                 else if(!scriptMode && !attributeMode && openedTag &&
+                        lastChars[3]=='<' && // Added this to make sure it's not <thead> this was messing up in screen with datatable
                         (lastChars[2]=='h' || lastChars[2]=='H') &&
                             (lastChars[1]=='e' || lastChars[1]=='E')&&
                                 (lastChars[0]=='a' || lastChars[1]=='A')&&



Re: svn commit: r326946 - /myfaces/tomahawk/trunk/src/java/org/apache/myfaces/component/html/util/ReducedHTMLParser.java

Posted by Travis Reeder <tr...@gmail.com>.
I'll change it to this:
(lastChars[3]=='<' || Character.isWhitespace(lastChars[3]))

Is it valid xml to have whitespace after the opening bracket?

Travis

On 10/20/05, Martin Marinschek <ma...@gmail.com> wrote:
> But what do we do with whitespace before head?
>
> then the parsing won't work as well...
>
> regards,
>
> Martin
>
> On 10/20/05, prophecy@apache.org <pr...@apache.org> wrote:
> > Author: prophecy
> > Date: Thu Oct 20 10:08:33 2005
> > New Revision: 326946
> >
> > URL: http://svn.apache.org/viewcvs?rev=326946&view=rev
> > Log:
> > was mistaking <thead> for <head> tag, fixed
> >
> > Modified:
> >     myfaces/tomahawk/trunk/src/java/org/apache/myfaces/component/html/util/ReducedHTMLParser.java
> >
> > Modified: myfaces/tomahawk/trunk/src/java/org/apache/myfaces/component/html/util/ReducedHTMLParser.java
> > URL: http://svn.apache.org/viewcvs/myfaces/tomahawk/trunk/src/java/org/apache/myfaces/component/html/util/ReducedHTMLParser.java?rev=326946&r1=326945&r2=326946&view=diff
> > ==============================================================================
> > --- myfaces/tomahawk/trunk/src/java/org/apache/myfaces/component/html/util/ReducedHTMLParser.java (original)
> > +++ myfaces/tomahawk/trunk/src/java/org/apache/myfaces/component/html/util/ReducedHTMLParser.java Thu Oct 20 10:08:33 2005
> > @@ -126,6 +126,7 @@
> >
> >                  }
> >                  else if(!scriptMode && !attributeMode && openedTag &&
> > +                        lastChars[3]=='<' && // Added this to make sure it's not <thead> this was messing up in screen with datatable
> >                          (lastChars[2]=='h' || lastChars[2]=='H') &&
> >                              (lastChars[1]=='e' || lastChars[1]=='E')&&
> >                                  (lastChars[0]=='a' || lastChars[1]=='A')&&
> >
> >
> >
>
>
> --
>
> http://www.irian.at
> Your JSF powerhouse -
> JSF Trainings in English and German
>

Re: svn commit: r326946 - /myfaces/tomahawk/trunk/src/java/org/apache/myfaces/component/html/util/ReducedHTMLParser.java

Posted by Martin Marinschek <ma...@gmail.com>.
But what do we do with whitespace before head?

then the parsing won't work as well...

regards,

Martin

On 10/20/05, prophecy@apache.org <pr...@apache.org> wrote:
> Author: prophecy
> Date: Thu Oct 20 10:08:33 2005
> New Revision: 326946
>
> URL: http://svn.apache.org/viewcvs?rev=326946&view=rev
> Log:
> was mistaking <thead> for <head> tag, fixed
>
> Modified:
>     myfaces/tomahawk/trunk/src/java/org/apache/myfaces/component/html/util/ReducedHTMLParser.java
>
> Modified: myfaces/tomahawk/trunk/src/java/org/apache/myfaces/component/html/util/ReducedHTMLParser.java
> URL: http://svn.apache.org/viewcvs/myfaces/tomahawk/trunk/src/java/org/apache/myfaces/component/html/util/ReducedHTMLParser.java?rev=326946&r1=326945&r2=326946&view=diff
> ==============================================================================
> --- myfaces/tomahawk/trunk/src/java/org/apache/myfaces/component/html/util/ReducedHTMLParser.java (original)
> +++ myfaces/tomahawk/trunk/src/java/org/apache/myfaces/component/html/util/ReducedHTMLParser.java Thu Oct 20 10:08:33 2005
> @@ -126,6 +126,7 @@
>
>                  }
>                  else if(!scriptMode && !attributeMode && openedTag &&
> +                        lastChars[3]=='<' && // Added this to make sure it's not <thead> this was messing up in screen with datatable
>                          (lastChars[2]=='h' || lastChars[2]=='H') &&
>                              (lastChars[1]=='e' || lastChars[1]=='E')&&
>                                  (lastChars[0]=='a' || lastChars[1]=='A')&&
>
>
>


--

http://www.irian.at
Your JSF powerhouse -
JSF Trainings in English and German