You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Venkata Siva Vijayendra Bhamidipati <vi...@citrix.com> on 2013/06/12 22:22:04 UTC
Review Request: Fix for NPE during ip range creation
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11850/
-----------------------------------------------------------
Review request for cloudstack, Chip Childers, Kelven Yang, bharat kumar, and Min Chen.
Description
-------
Fixing an NPE encountered when creating advanced zone. Exception stack trace provided in https://issues.apache.org/jira/browse/CLOUDSTACK-2969
This addresses bug CLOUDSTACK-2969.
Diffs
-----
server/src/com/cloud/configuration/ConfigurationManagerImpl.java 111586d
Diff: https://reviews.apache.org/r/11850/diff/
Testing
-------
Advanced zone creation proceeds correctly with fix in place.
Thanks,
Venkata Siva Vijayendra Bhamidipati
Re: Review Request: Fix for NPE during ip range creation
Posted by Sateesh Chodapuneedi <sa...@citrix.com>.
> On June 13, 2013, 5:34 a.m., Sateesh Chodapuneedi wrote:
> > LGTM.
Thanks for patch!
Committed the patch to master.
Commit: ff0a524bd689cc89f7ca48db84e6591edcd7c47c
- Sateesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11850/#review21838
-----------------------------------------------------------
On June 12, 2013, 8:22 p.m., Venkata Siva Vijayendra Bhamidipati wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11850/
> -----------------------------------------------------------
>
> (Updated June 12, 2013, 8:22 p.m.)
>
>
> Review request for cloudstack, Chip Childers, Kelven Yang, bharat kumar, and Min Chen.
>
>
> Description
> -------
>
> Fixing an NPE encountered when creating advanced zone. Exception stack trace provided in https://issues.apache.org/jira/browse/CLOUDSTACK-2969
>
>
> This addresses bug CLOUDSTACK-2969.
>
>
> Diffs
> -----
>
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java 111586d
>
> Diff: https://reviews.apache.org/r/11850/diff/
>
>
> Testing
> -------
>
> Advanced zone creation proceeds correctly with fix in place.
>
>
> Thanks,
>
> Venkata Siva Vijayendra Bhamidipati
>
>
Re: Review Request: Fix for NPE during ip range creation
Posted by Sateesh Chodapuneedi <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11850/#review21838
-----------------------------------------------------------
Ship it!
LGTM.
- Sateesh Chodapuneedi
On June 12, 2013, 8:22 p.m., Venkata Siva Vijayendra Bhamidipati wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11850/
> -----------------------------------------------------------
>
> (Updated June 12, 2013, 8:22 p.m.)
>
>
> Review request for cloudstack, Chip Childers, Kelven Yang, bharat kumar, and Min Chen.
>
>
> Description
> -------
>
> Fixing an NPE encountered when creating advanced zone. Exception stack trace provided in https://issues.apache.org/jira/browse/CLOUDSTACK-2969
>
>
> This addresses bug CLOUDSTACK-2969.
>
>
> Diffs
> -----
>
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java 111586d
>
> Diff: https://reviews.apache.org/r/11850/diff/
>
>
> Testing
> -------
>
> Advanced zone creation proceeds correctly with fix in place.
>
>
> Thanks,
>
> Venkata Siva Vijayendra Bhamidipati
>
>