You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Venki Korukanti <ve...@gmail.com> on 2014/05/20 05:09:56 UTC
Review Request 21679: HIVE-6245: HS2 creates DBs/Tables with wrong ownership
when HMS setugi is true
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21679/
-----------------------------------------------------------
Review request for hive, Thejas Nair and Vaibhav Gumashta.
Bugs: HIVE-6245
https://issues.apache.org/jira/browse/HIVE-6245
Repository: hive-git
Description
-------
Instead of creating Hive object when authentication type is "KERBEROS", always create the Hive object HiveSessionImplWithUGI is created when user impersonation is needed.
Diffs
-----
itests/hive-unit/src/test/java/org/apache/hive/service/TestHS2WithRemoteMS.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 5a56ced
service/src/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java e79b129
Diff: https://reviews.apache.org/r/21679/diff/
Testing
-------
Patch includes a test.
Thanks,
Venki Korukanti
Re: Review Request 21679: HIVE-6245: HS2 creates DBs/Tables with wrong
ownership when HMS setugi is true
Posted by Venki Korukanti <ve...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21679/
-----------------------------------------------------------
(Updated Aug. 28, 2014, 7:25 a.m.)
Review request for hive, Navis Ryu, Thejas Nair, and Vaibhav Gumashta.
Changes
-------
Addressed review comments.
Bugs: HIVE-6245
https://issues.apache.org/jira/browse/HIVE-6245
Repository: hive-git
Description
-------
Instead of creating Hive object when authentication type is "KERBEROS", always create the Hive object in HiveSessionImplWithUGI. HiveSessionImplWithUGI is created when user impersonation is needed.
Diffs (updated)
-----
itests/hive-unit/src/main/java/org/apache/hive/jdbc/miniHS2/MiniHS2.java 4502439
itests/hive-unit/src/test/java/org/apache/hive/service/TestHS2ImpersonationWithRemoteMS.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 51c3f2c
service/src/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java 39d2184
Diff: https://reviews.apache.org/r/21679/diff/
Testing
-------
Patch includes a test.
Thanks,
Venki Korukanti
Re: Review Request 21679: HIVE-6245: HS2 creates DBs/Tables with wrong
ownership when HMS setugi is true
Posted by Thejas Nair <th...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21679/#review51256
-----------------------------------------------------------
itests/hive-unit/src/main/java/org/apache/hive/jdbc/miniHS2/MiniHS2.java
<https://reviews.apache.org/r/21679/#comment89357>
please use a name that better indicates that it is a boolean. eg isRemoteMetastore
itests/hive-unit/src/main/java/org/apache/hive/jdbc/miniHS2/MiniHS2.java
<https://reviews.apache.org/r/21679/#comment89358>
this status is unused
- Thejas Nair
On Aug. 20, 2014, 10:33 p.m., Venki Korukanti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21679/
> -----------------------------------------------------------
>
> (Updated Aug. 20, 2014, 10:33 p.m.)
>
>
> Review request for hive, Navis Ryu, Thejas Nair, and Vaibhav Gumashta.
>
>
> Bugs: HIVE-6245
> https://issues.apache.org/jira/browse/HIVE-6245
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Instead of creating Hive object when authentication type is "KERBEROS", always create the Hive object in HiveSessionImplWithUGI. HiveSessionImplWithUGI is created when user impersonation is needed.
>
>
> Diffs
> -----
>
> itests/hive-unit/src/main/java/org/apache/hive/jdbc/miniHS2/MiniHS2.java 4502439
> itests/hive-unit/src/test/java/org/apache/hive/service/TestHS2ImpersonationWithRemoteMS.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 51c3f2c
> service/src/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java 39d2184
>
> Diff: https://reviews.apache.org/r/21679/diff/
>
>
> Testing
> -------
>
> Patch includes a test.
>
>
> Thanks,
>
> Venki Korukanti
>
>
Re: Review Request 21679: HIVE-6245: HS2 creates DBs/Tables with wrong
ownership when HMS setugi is true
Posted by Venki Korukanti <ve...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21679/
-----------------------------------------------------------
(Updated Aug. 20, 2014, 10:33 p.m.)
Review request for hive, Navis Ryu, Thejas Nair, and Vaibhav Gumashta.
Bugs: HIVE-6245
https://issues.apache.org/jira/browse/HIVE-6245
Repository: hive-git
Description
-------
Instead of creating Hive object when authentication type is "KERBEROS", always create the Hive object in HiveSessionImplWithUGI. HiveSessionImplWithUGI is created when user impersonation is needed.
Diffs (updated)
-----
itests/hive-unit/src/main/java/org/apache/hive/jdbc/miniHS2/MiniHS2.java 4502439
itests/hive-unit/src/test/java/org/apache/hive/service/TestHS2ImpersonationWithRemoteMS.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 51c3f2c
service/src/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java 39d2184
Diff: https://reviews.apache.org/r/21679/diff/
Testing
-------
Patch includes a test.
Thanks,
Venki Korukanti
Re: Review Request 21679: HIVE-6245: HS2 creates DBs/Tables with wrong
ownership when HMS setugi is true
Posted by Venki Korukanti <ve...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21679/
-----------------------------------------------------------
(Updated May 20, 2014, 3:12 a.m.)
Review request for hive, Thejas Nair and Vaibhav Gumashta.
Bugs: HIVE-6245
https://issues.apache.org/jira/browse/HIVE-6245
Repository: hive-git
Description (updated)
-------
Instead of creating Hive object when authentication type is "KERBEROS", always create the Hive object in HiveSessionImplWithUGI. HiveSessionImplWithUGI is created when user impersonation is needed.
Diffs
-----
itests/hive-unit/src/test/java/org/apache/hive/service/TestHS2WithRemoteMS.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 5a56ced
service/src/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java e79b129
Diff: https://reviews.apache.org/r/21679/diff/
Testing
-------
Patch includes a test.
Thanks,
Venki Korukanti