[GitHub] [beam] liferoad commented on a diff in pull request #26714: Log the exception's cause when failed to parse TableRow

["liferoad (via GitHub)" <gi...@apache.org>]

liferoad commented on code in PR #26714:
URL: https://github.com/apache/beam/pull/26714#discussion_r1195383215


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiWriteUnshardedRecords.java:
##########
@@ -571,7 +571,7 @@ long flush(
                             failedRow, error.getRowIndexToErrorMessage().get(failedIndex)),
                         timestamp);
                   } catch (InvalidProtocolBufferException e) {
-                    LOG.error("Failed to insert row and could not parse the result!");
+                    LOG.error("Failed to insert row and could not parse the result!", e);

Review Comment:
   Do we need to warn the potential data loss? Can we add some actionable steps for users such as validate the data schema matches the given one?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org