You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2017/12/07 23:58:19 UTC

[GitHub] mbaijal opened a new pull request #8991: Fix example parallel actor

mbaijal opened a new pull request #8991: Fix example parallel actor
URL: https://github.com/apache/incubator-mxnet/pull/8991
 
 
   ## Description ##
   Does not run with python 3.x due to usage of `xrange`
   The default environment `PongDeterministic-v3` is deprecated. 
   Some updates to Readme needed
   
   ## Checklist ##
   ### Essentials ###
   - [ ] Passed code style checking (`make lint`)
   - [ ] Changes are complete (i.e. I finished coding on this PR)
   - [ ] All changes have test coverage
   - [ ] For user-facing API changes, API doc string has been updated. For new C++ functions in header files, their functionalities and arguments are well-documented. 
   - [ ] To my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
   
   ### Changes ###
   - [ ] example/reinforcement-learning/parallel_actor_critic/model.py uses xrange() in line 91. This has been changed to range() in python3
   - [ ] The default env as PongDeterministic-v3. However this is deprecated. Changed to PongDeterministic-v4 
   - [ ] Some updates to README
   
   ## Comments ##
    - I have tested on the Deep Learning AMI with Conda (Ubuntu) (ami-405ade3a)
    - I have verified that the change for python 3.x does not break the example on python 2.x
    - I have not verified the accuracy or validity of results.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services