You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@struts.apache.org by "kusalk (via GitHub)" <gi...@apache.org> on 2025/02/24 09:38:47 UTC
[PR] WW-5532 Upgrade and align various dependencies [struts]
kusalk opened a new pull request, #1232:
URL: https://github.com/apache/struts/pull/1232
WW-5532
--
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WW-5532 Upgrade and align various dependencies [struts]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #1232:
URL: https://github.com/apache/struts/pull/1232#issuecomment-2677889657
## [](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=1232) **Quality Gate failed**
Failed conditions
 [7 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_struts&pullRequest=1232&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [71.3% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=1232&metric=new_coverage&view=list) (required ≥ 80%)
 [E Security Rating on New Code](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=1232) (required ≥ A)
 [C Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=1232) (required ≥ A)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=1232)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WW-5532 Upgrade and align various dependencies [struts]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #1232:
URL: https://github.com/apache/struts/pull/1232#issuecomment-2677901802
## [](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=1232) **Quality Gate failed**
Failed conditions
 [7 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_struts&pullRequest=1232&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [71.3% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=1232&metric=new_coverage&view=list) (required ≥ 80%)
 [C Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=1232) (required ≥ A)
 [E Security Rating on New Code](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=1232) (required ≥ A)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=1232)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WW-5532 Upgrade and align various dependencies [struts]
Posted by "kusalk (via GitHub)" <gi...@apache.org>.
kusalk merged PR #1232:
URL: https://github.com/apache/struts/pull/1232
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WW-5532 Upgrade and align various dependencies [struts]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #1232:
URL: https://github.com/apache/struts/pull/1232#issuecomment-2677987460
## [](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=1232) **Quality Gate failed**
Failed conditions
 [7 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_struts&pullRequest=1232&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [71.3% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=1232&metric=new_coverage&view=list) (required ≥ 80%)
 [C Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=1232) (required ≥ A)
 [E Security Rating on New Code](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=1232) (required ≥ A)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=1232)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WW-5532 Upgrade and align various dependencies [struts]
Posted by "lukaszlenart (via GitHub)" <gi...@apache.org>.
lukaszlenart commented on code in PR #1232:
URL: https://github.com/apache/struts/pull/1232#discussion_r1967682401
##########
pom.xml:
##########
@@ -900,52 +806,12 @@
</dependency>
<dependency>
- <groupId>com.fasterxml.jackson.core</groupId>
- <artifactId>jackson-core</artifactId>
- <version>${jackson.version}</version>
- </dependency>
- <dependency>
- <groupId>com.fasterxml.jackson.core</groupId>
- <artifactId>jackson-databind</artifactId>
+ <groupId>com.fasterxml.jackson</groupId>
+ <artifactId>jackson-bom</artifactId>
<version>${jackson.version}</version>
+ <type>pom</type>
+ <scope>import</scope>
</dependency>
- <dependency>
- <groupId>com.fasterxml.jackson.dataformat</groupId>
- <artifactId>jackson-dataformat-xml</artifactId>
- <version>${jackson.version}</version>
- </dependency>
-
- <dependency>
- <groupId>org.apache.juneau</groupId>
- <artifactId>juneau-marshall</artifactId>
- <version>8.1.3</version>
- </dependency>
Review Comment:
Why did you remove this dependency from <dependencyManagement/> section?
##########
plugins/rest/pom.xml:
##########
@@ -58,6 +58,7 @@
<dependency>
<groupId>org.apache.juneau</groupId>
<artifactId>juneau-marshall</artifactId>
+ <version>8.1.3</version>
Review Comment:
Version is already defined in the parent pom
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WW-5532 Upgrade and align various dependencies [struts]
Posted by "lukaszlenart (via GitHub)" <gi...@apache.org>.
lukaszlenart commented on code in PR #1232:
URL: https://github.com/apache/struts/pull/1232#discussion_r1968991272
##########
pom.xml:
##########
@@ -900,52 +806,12 @@
</dependency>
<dependency>
- <groupId>com.fasterxml.jackson.core</groupId>
- <artifactId>jackson-core</artifactId>
- <version>${jackson.version}</version>
- </dependency>
- <dependency>
- <groupId>com.fasterxml.jackson.core</groupId>
- <artifactId>jackson-databind</artifactId>
+ <groupId>com.fasterxml.jackson</groupId>
+ <artifactId>jackson-bom</artifactId>
<version>${jackson.version}</version>
+ <type>pom</type>
+ <scope>import</scope>
</dependency>
- <dependency>
- <groupId>com.fasterxml.jackson.dataformat</groupId>
- <artifactId>jackson-dataformat-xml</artifactId>
- <version>${jackson.version}</version>
- </dependency>
-
- <dependency>
- <groupId>org.apache.juneau</groupId>
- <artifactId>juneau-marshall</artifactId>
- <version>8.1.3</version>
- </dependency>
Review Comment:
That's fine yet I would like to adopt the same approach as described here [WW-5376](https://issues.apache.org/jira/browse/WW-5376)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WW-5532 Upgrade and align various dependencies [struts]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #1232:
URL: https://github.com/apache/struts/pull/1232#issuecomment-2677966919
## [](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=1232) **Quality Gate failed**
Failed conditions
 [7 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_struts&pullRequest=1232&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [71.3% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=1232&metric=new_coverage&view=list) (required ≥ 80%)
 [E Security Rating on New Code](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=1232) (required ≥ A)
 [C Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=1232) (required ≥ A)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=1232)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WW-5532 Upgrade and align various dependencies [struts]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #1232:
URL: https://github.com/apache/struts/pull/1232#issuecomment-2680134015
## [](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=1232) **Quality Gate failed**
Failed conditions
 [7 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_struts&pullRequest=1232&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [71.3% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=1232&metric=new_coverage&view=list) (required ≥ 80%)
 [E Security Rating on New Code](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=1232) (required ≥ A)
 [C Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=1232) (required ≥ A)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=1232)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WW-5532 Upgrade and align various dependencies [struts]
Posted by "kusalk (via GitHub)" <gi...@apache.org>.
kusalk commented on code in PR #1232:
URL: https://github.com/apache/struts/pull/1232#discussion_r1968683115
##########
pom.xml:
##########
@@ -900,52 +806,12 @@
</dependency>
<dependency>
- <groupId>com.fasterxml.jackson.core</groupId>
- <artifactId>jackson-core</artifactId>
- <version>${jackson.version}</version>
- </dependency>
- <dependency>
- <groupId>com.fasterxml.jackson.core</groupId>
- <artifactId>jackson-databind</artifactId>
+ <groupId>com.fasterxml.jackson</groupId>
+ <artifactId>jackson-bom</artifactId>
<version>${jackson.version}</version>
+ <type>pom</type>
+ <scope>import</scope>
</dependency>
- <dependency>
- <groupId>com.fasterxml.jackson.dataformat</groupId>
- <artifactId>jackson-dataformat-xml</artifactId>
- <version>${jackson.version}</version>
- </dependency>
-
- <dependency>
- <groupId>org.apache.juneau</groupId>
- <artifactId>juneau-marshall</artifactId>
- <version>8.1.3</version>
- </dependency>
Review Comment:
I moved version management for dependencies that are specific to only 1 plugin and are unlikely to ever be needed elsewhere as I thought it made the root POM slightly neater. I did the same with the Weld dependencies which are specific to the CDI plugin.
But I don't have a strong opinion here and am happy to revert these specific changes, let me know what your preference is 🙂
It'd be good to be consistent though, so if we decide to keep them in the root POM, I'd like to version manage the other dependencies that are currently only defined in their plugins (e.g. `org.jfree:jfreechart`, `net.sf.jasperreports:jasperreports` and any others).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WW-5532 Upgrade and align various dependencies [struts]
Posted by "kusalk (via GitHub)" <gi...@apache.org>.
kusalk commented on code in PR #1232:
URL: https://github.com/apache/struts/pull/1232#discussion_r1969258489
##########
pom.xml:
##########
@@ -900,52 +806,12 @@
</dependency>
<dependency>
- <groupId>com.fasterxml.jackson.core</groupId>
- <artifactId>jackson-core</artifactId>
- <version>${jackson.version}</version>
- </dependency>
- <dependency>
- <groupId>com.fasterxml.jackson.core</groupId>
- <artifactId>jackson-databind</artifactId>
+ <groupId>com.fasterxml.jackson</groupId>
+ <artifactId>jackson-bom</artifactId>
<version>${jackson.version}</version>
+ <type>pom</type>
+ <scope>import</scope>
</dependency>
- <dependency>
- <groupId>com.fasterxml.jackson.dataformat</groupId>
- <artifactId>jackson-dataformat-xml</artifactId>
- <version>${jackson.version}</version>
- </dependency>
-
- <dependency>
- <groupId>org.apache.juneau</groupId>
- <artifactId>juneau-marshall</artifactId>
- <version>8.1.3</version>
- </dependency>
Review Comment:
I've got a follow-up PR addressing that!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org