You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/06/27 06:20:28 UTC

[GitHub] [airflow] uranusjr commented on a change in pull request #16668: Refactor: added type annotation

uranusjr commented on a change in pull request #16668:
URL: https://github.com/apache/airflow/pull/16668#discussion_r659269759



##########
File path: tests/build_provider_packages_dependencies.py
##########
@@ -114,13 +114,14 @@ class ImportFinder(NodeVisitor):
     AST visitor that collects all imported names in its imports
     """
 
-    def __init__(self, filename):
+    def __init__(self, filename: str) -> None:
+        
         self.imports: List[str] = []
-        self.filename = filename
+        self.filename: str = filename

Review comment:
       I don’t think this is needed, Mypy is able to infer this from the argument type IIRC.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org