You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/11/14 03:56:05 UTC

[GitHub] [dubbo-go-samples] justxuewei commented on a change in pull request #297: make generic and rpc/dubbo runs

justxuewei commented on a change in pull request #297:
URL: https://github.com/apache/dubbo-go-samples/pull/297#discussion_r748794310



##########
File path: generic/default/go-client/pkg/user.go
##########
@@ -22,7 +22,7 @@ import (
 )
 
 type User struct {
-	ID   string
+	Id   string

Review comment:
       这个地方我觉得现在泛化调用机械式的把 ID -> iD 不是很合理，应该需要一个 utils，把 ID -> id 以符合 java 的习惯。




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org