You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "zhuangchong (via GitHub)" <gi...@apache.org> on 2023/03/28 08:01:35 UTC
[GitHub] [incubator-paimon] zhuangchong opened a new pull request, #725: [test] Improve using junit5 test logger extension in flink test module
zhuangchong opened a new pull request, #725:
URL: https://github.com/apache/incubator-paimon/pull/725
*(Please specify the module before the PR name: [core] ... or [flink] ...)*
### Purpose
*(What is the purpose of the change, or the associated issue)*
### Tests
*(List UT and IT cases to verify this change)*
### API and Format
*(Does this change affect API or storage format)*
### Documentation
*(Does this change introduce a new feature)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] JingsongLi commented on pull request #725: [test] Improve using junit5 test logger extension in flink test module
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on PR #725:
URL: https://github.com/apache/incubator-paimon/pull/725#issuecomment-1489789055
> > What's the benefit? I don't get it.
>
> TestLogger is a `junit-4-style` test logger.
>
> TestLoggerExtension is a `junit-5-style` test logger.
>
> This pr is to change TestLogger to use TestLoggerExtension.
Thanks for the explanation. Sounds good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] JingsongLi merged pull request #725: [test] Improve using junit5 test logger extension in flink test module
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi merged PR #725:
URL: https://github.com/apache/incubator-paimon/pull/725
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] JingsongLi commented on pull request #725: [test] Improve using junit5 test logger extension in flink test module
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on PR #725:
URL: https://github.com/apache/incubator-paimon/pull/725#issuecomment-1486728744
What's the benefit? I don't get it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] zhuangchong commented on pull request #725: [test] Improve using junit5 test logger extension in flink test module
Posted by "zhuangchong (via GitHub)" <gi...@apache.org>.
zhuangchong commented on PR #725:
URL: https://github.com/apache/incubator-paimon/pull/725#issuecomment-1487954410
> What's the benefit? I don't get it.
TestLogger is a `junit-4-style` test logger.
TestLoggerExtension is a `junit-5-style` test logger.
This pr is to change TestLogger to use TestLoggerExtension.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org