You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by zh...@apache.org on 2023/02/14 05:51:09 UTC

[rocketmq] 14/18: Remove enableBuildConsumeQueueConcurrently attribute from BrokerConfig class

This is an automated email from the ASF dual-hosted git repository.

zhouxzhan pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git

commit c2ea0922b714a9dbdc152a537570c9aa3e707767
Author: nowinkey <no...@tom.com>
AuthorDate: Sat Feb 11 18:17:55 2023 +0800

    Remove enableBuildConsumeQueueConcurrently attribute from BrokerConfig class
---
 .../main/java/org/apache/rocketmq/common/BrokerConfig.java   | 12 ------------
 .../java/org/apache/rocketmq/store/DefaultMessageStore.java  |  4 ++--
 2 files changed, 2 insertions(+), 14 deletions(-)

diff --git a/common/src/main/java/org/apache/rocketmq/common/BrokerConfig.java b/common/src/main/java/org/apache/rocketmq/common/BrokerConfig.java
index 3d4994f53..454b96cd5 100644
--- a/common/src/main/java/org/apache/rocketmq/common/BrokerConfig.java
+++ b/common/src/main/java/org/apache/rocketmq/common/BrokerConfig.java
@@ -401,10 +401,6 @@ public class BrokerConfig extends BrokerIdentity {
      */
     private boolean estimateAccumulation = true;
 
-    /**
-     * Build ConsumeQueue concurrently with multi-thread
-     */
-    private boolean enableBuildConsumeQueueConcurrently = false;
 
     public long getMaxPopPollingSize() {
         return maxPopPollingSize;
@@ -1661,12 +1657,4 @@ public class BrokerConfig extends BrokerIdentity {
     public void setBatchDispatchRequestThreadPoolNums(int batchDispatchRequestThreadPoolNums) {
         this.batchDispatchRequestThreadPoolNums = batchDispatchRequestThreadPoolNums;
     }
-
-    public boolean isEnableBuildConsumeQueueConcurrently() {
-        return enableBuildConsumeQueueConcurrently;
-    }
-
-    public void setEnableBuildConsumeQueueConcurrently(boolean enableBuildConsumeQueueConcurrently) {
-        this.enableBuildConsumeQueueConcurrently = enableBuildConsumeQueueConcurrently;
-    }
 }
diff --git a/store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java b/store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java
index 727bc5c00..ba4b53064 100644
--- a/store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java
+++ b/store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java
@@ -234,7 +234,7 @@ public class DefaultMessageStore implements MessageStore {
             }
         }
 
-        if (!brokerConfig.isEnableBuildConsumeQueueConcurrently()) {
+        if (!messageStoreConfig.isEnableBuildConsumeQueueConcurrently()) {
             this.reputMessageService = new ReputMessageService();
         } else {
             this.reputMessageService = new ConcurrentReputMessageService();
@@ -689,7 +689,7 @@ public class DefaultMessageStore implements MessageStore {
 
         this.recoverTopicQueueTable();
 
-        if (!brokerConfig.isEnableBuildConsumeQueueConcurrently()) {
+        if (!messageStoreConfig.isEnableBuildConsumeQueueConcurrently()) {
             this.reputMessageService = new ReputMessageService();
         } else {
             this.reputMessageService = new ConcurrentReputMessageService();