You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/07/08 22:26:01 UTC
[GitHub] [orc] kbendick commented on a change in pull request #741: ORC-835: Cache TRUE/FALSE Bytes in StringGroupFromBooleanTreeReader
kbendick commented on a change in pull request #741:
URL: https://github.com/apache/orc/pull/741#discussion_r666555681
##########
File path: java/core/src/java/org/apache/orc/impl/ConvertTreeReaderFactory.java
##########
@@ -1068,6 +1068,8 @@ public void nextVector(ColumnVector previousVector,
}
public static class StringGroupFromBooleanTreeReader extends StringGroupFromAnyIntegerTreeReader {
+ private static final byte[] TRUE_BYTES = "TRUE".getBytes(StandardCharsets.US_ASCII);
+ private static final byte[] FALSE_BYTES = "FALSE".getBytes(StandardCharsets.US_ASCII);
Review comment:
In my opinion, it would be better to continue to use the UTF_8 charset to reduce the impact of this change.
Is there a benefit to not using it? My understanding is that the final result should be more or less equivalent because the letters are part of ASCII but I'm not an expert on UTF8 codepoints.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org