You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/01/12 07:58:16 UTC

[GitHub] [tvm] lixiaoquan commented on pull request #7237: [ONNX] Fix issues for Clip and RoiAlign

lixiaoquan commented on pull request #7237:
URL: https://github.com/apache/tvm/pull/7237#issuecomment-758478199


   > Maybe you can tell us what the issue was.
   
   For RoiAlign, 1) attr.get(“mode", "avg”) will return a string "avg" as default value, which always fails the following test `if avg == b"avg"` 2) infer_type(rois).type_annotation only works when rois is variable, but it could be CallNode
   
   For Clip  1) It is possible "min"/"max" don't exist in attrs 
   
    


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org