You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by bn...@apache.org on 2021/09/22 19:36:03 UTC

[trafficserver] 01/01: unit_tests/test_MemArena: fix memory leak on arena.make tests

This is an automated email from the ASF dual-hosted git repository.

bnolsen pushed a commit to branch memarena_test_leak
in repository https://gitbox.apache.org/repos/asf/trafficserver.git

commit 31d8a1dd6d4dad462618756c45f0b75c21df1e94
Author: Brian Olsen <br...@comcast.com>
AuthorDate: Wed Sep 22 19:35:31 2021 +0000

    unit_tests/test_MemArena: fix memory leak on arena.make tests
---
 src/tscore/unit_tests/test_MemArena.cc | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/src/tscore/unit_tests/test_MemArena.cc b/src/tscore/unit_tests/test_MemArena.cc
index 4084afe..e889c69 100644
--- a/src/tscore/unit_tests/test_MemArena.cc
+++ b/src/tscore/unit_tests/test_MemArena.cc
@@ -151,30 +151,41 @@ TEST_CASE("MemArena helper", "[libts][MemArena]")
   REQUIRE(!arena.contains((char *)ptr));
   REQUIRE(arena.contains((char *)ptr2));
 
+  std::vector<Thing *> things;
+
   Thing *thing_one{arena.make<Thing>()};
+  things.push_back(thing_one);
 
   REQUIRE(thing_one->ten == 10);
   REQUIRE(thing_one->name == "name");
 
   thing_one = arena.make<Thing>(17, "bob"sv);
+  things.push_back(thing_one);
 
   REQUIRE(thing_one->name == "bob");
   REQUIRE(thing_one->ten == 17);
 
   thing_one = arena.make<Thing>("Dave", 137);
+  things.push_back(thing_one);
 
   REQUIRE(thing_one->name == "Dave");
   REQUIRE(thing_one->ten == 137);
 
   thing_one = arena.make<Thing>(9999);
+  things.push_back(thing_one);
 
   REQUIRE(thing_one->ten == 9999);
   REQUIRE(thing_one->name == "name");
 
   thing_one = arena.make<Thing>("Persia");
+  things.push_back(thing_one);
 
   REQUIRE(thing_one->ten == 10);
   REQUIRE(thing_one->name == "Persia");
+
+  for (auto thing : things) {
+    delete thing;
+  }
 }
 
 TEST_CASE("MemArena large alloc", "[libts][MemArena]")