You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "Mike Beckerle (Jira)" <ji...@apache.org> on 2021/01/21 20:52:00 UTC
[jira] [Closed] (DAFFODIL-1785) SimpleTypeRuntimeData facet
evaluation causes slow compile time
[ https://issues.apache.org/jira/browse/DAFFODIL-1785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Beckerle closed DAFFODIL-1785.
-----------------------------------
Resolution: Cannot Reproduce
Need profiling.
> SimpleTypeRuntimeData facet evaluation causes slow compile time
> ---------------------------------------------------------------
>
> Key: DAFFODIL-1785
> URL: https://issues.apache.org/jira/browse/DAFFODIL-1785
> Project: Daffodil
> Issue Type: Bug
> Components: Back End, Middle "End"
> Reporter: Steve Lawrence
> Priority: Major
>
> The code in Facets.scala and RestrictionUnion.scala appears to cause a notcable hit in performance (maybe 20% on a very large file with lots of restrictions). If I replace all the facet information in in the��SimpleTypeRuntimeData constructor with Nil's and None's, compile time decreases. I suspect there are some performance improvements we can make with Facets.scal and ResttrictoinUntion. A quick cursory sees some duplicating effort (e.g. multiple calls to xml
> "restriction", which is probably pretty slow itself. Facets.scala is kindof messy and hard to read, so a redisgn/refactoring might make it easier to improve this aspect of compilation.
> Also, removing the requiredEvaluations in Facets.scala also helps quite a bit. Seems perhaps the pattern one might be the worse offender.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)