You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/11/05 03:35:17 UTC
[GitHub] [flink] leonardBang commented on a diff in pull request #21241: [hotfix][doc] add `INTERVAL` subtraction into the example and update the related description
leonardBang commented on code in PR #21241:
URL: https://github.com/apache/flink/pull/21241#discussion_r1014556699
##########
docs/content/docs/dev/table/sql/queries/joins.md:
##########
@@ -154,7 +154,7 @@ CREATE TABLE currency_rates (
currency STRING,
conversion_rate DECIMAL(32, 2),
update_time TIMESTAMP(3) METADATA FROM `values.source.timestamp` VIRTUAL,
- WATERMARK FOR update_time AS update_time,
+ WATERMARK FOR update_time AS update_time - INTERVAL '15' SECONDS,
Review Comment:
```suggestion
WATERMARK FOR update_time AS update_time - INTERVAL '15' SECOND,
```
##########
docs/content/docs/dev/table/sql/queries/joins.md:
##########
@@ -143,7 +143,7 @@ CREATE TABLE orders (
price DECIMAL(32,2),
currency STRING,
order_time TIMESTAMP(3),
- WATERMARK FOR order_time AS order_time
+ WATERMARK FOR order_time AS order_time - INTERVAL '15' SECONDS
Review Comment:
```suggestion
WATERMARK FOR order_time AS order_time - INTERVAL '15' SECOND
```
##########
docs/content.zh/docs/dev/table/sql/queries/joins.md:
##########
@@ -143,7 +143,7 @@ CREATE TABLE orders (
price DECIMAL(32,2),
currency STRING,
order_time TIMESTAMP(3),
- WATERMARK FOR order_time AS order_time
+ WATERMARK FOR order_time AS order_time - INTERVAL '15' SECONDS
Review Comment:
```suggestion
WATERMARK FOR order_time AS order_time - INTERVAL '15' SECOND
```
##########
docs/content.zh/docs/dev/table/sql/queries/joins.md:
##########
@@ -154,7 +154,7 @@ CREATE TABLE currency_rates (
currency STRING,
conversion_rate DECIMAL(32, 2),
update_time TIMESTAMP(3) METADATA FROM `values.source.timestamp` VIRTUAL,
- WATERMARK FOR update_time AS update_time,
+ WATERMARK FOR update_time AS update_time - INTERVAL '15' SECONDS,
Review Comment:
```suggestion
WATERMARK FOR update_time AS update_time - INTERVAL '15' SECOND,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org