You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2023/02/13 21:35:49 UTC
[Impala-ASF-CR] IMPALA-11920: Support spill to HDFS address by service ID
Hello Yida Wu, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19496
to look at the new patch set (#2).
Change subject: IMPALA-11920: Support spill to HDFS address by service ID
......................................................................
IMPALA-11920: Support spill to HDFS address by service ID
Allows addressing HDFS (and Ozone) filesystems in `scratch_dirs` by a
service identifier that doesn't include a port number.
Updates documentation to include examples with service identifier. Also
fixes inconsistent use of ASCII quotes for example text, highlighting
code and variable names, and normalizes descriptions between
S3/HDFS/Ozone. Removes "priority" from remote descriptions as it is
optional and does nothing.
Testing:
- new backend test cases run with HDFS and Ozone
- manually tested that Impala starts with
--impalad_args=--scratch_dirs=ofs://localhost/tmp,/tmp
creates impala-scratch in both locations
Change-Id: Ie069cba211df85fe90d174900b20a26fcc1f7167
---
M be/src/runtime/tmp-file-mgr-test.cc
M be/src/runtime/tmp-file-mgr.cc
M docs/topics/impala_disk_space.xml
3 files changed, 123 insertions(+), 84 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/19496/2
--
To view, visit http://gerrit.cloudera.org:8080/19496
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie069cba211df85fe90d174900b20a26fcc1f7167
Gerrit-Change-Number: 19496
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>