You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2016/12/23 00:39:41 UTC
[kudu-CR](branch-1.2.x) KUDU-1812: redact HexDump output
Dan Burkert has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5571
Change subject: KUDU-1812: redact HexDump output
......................................................................
KUDU-1812: redact HexDump output
After auditing calls to HexDump across the (non-test) Kudu codebase, it
was found that all calls would require manual redaction. Instead of
requiring callers to manually redact, it's easier to do it centrally.
Change-Id: I8388b19801382c491c9bcd9a485b1978ec0f007e
Reviewed-on: http://gerrit.cloudera.org:8080/5567
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Adar Dembo <ad...@cloudera.com>
(cherry picked from commit 47f09e30fde1726531544ba530651af39d9aa29e)
---
M src/kudu/util/hexdump.cc
M src/kudu/util/hexdump.h
2 files changed, 12 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/71/5571/1
--
To view, visit http://gerrit.cloudera.org:8080/5571
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8388b19801382c491c9bcd9a485b1978ec0f007e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.2.x
Gerrit-Owner: Dan Burkert <da...@apache.org>
[kudu-CR](branch-1.2.x) KUDU-1812: redact HexDump output
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: KUDU-1812: redact HexDump output
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5571
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8388b19801382c491c9bcd9a485b1978ec0f007e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.2.x
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR](branch-1.2.x) KUDU-1812: redact HexDump output
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged.
Change subject: KUDU-1812: redact HexDump output
......................................................................
KUDU-1812: redact HexDump output
After auditing calls to HexDump across the (non-test) Kudu codebase, it
was found that all calls would require manual redaction. Instead of
requiring callers to manually redact, it's easier to do it centrally.
Change-Id: I8388b19801382c491c9bcd9a485b1978ec0f007e
Reviewed-on: http://gerrit.cloudera.org:8080/5567
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Adar Dembo <ad...@cloudera.com>
(cherry picked from commit 47f09e30fde1726531544ba530651af39d9aa29e)
Reviewed-on: http://gerrit.cloudera.org:8080/5571
Reviewed-by: Dan Burkert <da...@apache.org>
---
M src/kudu/util/hexdump.cc
M src/kudu/util/hexdump.h
2 files changed, 12 insertions(+), 5 deletions(-)
Approvals:
Dan Burkert: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5571
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8388b19801382c491c9bcd9a485b1978ec0f007e
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: branch-1.2.x
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins