[GitHub] [arrow-datafusion] jdye64 commented on a diff in pull request #7034: Decimal256 coercion

["jdye64 (via GitHub)" <gi...@apache.org>]

jdye64 commented on code in PR #7034:
URL: https://github.com/apache/arrow-datafusion/pull/7034#discussion_r1269891091


##########
datafusion/expr/src/type_coercion/aggregates.rs:
##########
@@ -480,7 +480,7 @@ pub fn is_avg_support_arg_type(arg_type: &DataType) -> bool {
         _ => matches!(
             arg_type,
             arg_type if NUMERICS.contains(arg_type)
-                || matches!(arg_type, DataType::Decimal128(_, _))
+                || matches!(arg_type, DataType::Decimal128(_, _)| DataType::Decimal256(_, _))

Review Comment:
   hmm yes, I was under the impression that it should. In Dask-Sql's case we are not using the physical planner from DataFusion and rather using our own so maybe this error is coming in from some similar missed `Decimal256` coverage there? That would also explain why I don't see this issue when running as a library with dask-sql I guess?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org