You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/06/04 12:52:49 UTC
[GitHub] [hive] pvary opened a new pull request #2352: HIVE-25201: Remove Caffein shading from Iceberg
pvary opened a new pull request #2352:
URL: https://github.com/apache/hive/pull/2352
### What changes were proposed in this pull request?
Remove benmanes caffeine shading
### Why are the changes needed?
So we do not include 2 versions of Caffeine cache which is not really needed
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Unit tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary merged pull request #2352: HIVE-25201: Remove Caffein shading from Iceberg
Posted by GitBox <gi...@apache.org>.
pvary merged pull request #2352:
URL: https://github.com/apache/hive/pull/2352
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on a change in pull request #2352: HIVE-25201: Remove Caffein shading from Iceberg
Posted by GitBox <gi...@apache.org>.
pvary commented on a change in pull request #2352:
URL: https://github.com/apache/hive/pull/2352#discussion_r645634705
##########
File path: iceberg/iceberg-shading/pom.xml
##########
@@ -121,7 +117,6 @@
<include>org.apache.parquet:*</include>
<include>com.google*:*</include>
<include>com.fasterxml*:*</include>
- <include>com.github.ben-manes*:*</include>
Review comment:
Fixed. Good catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] marton-bod commented on a change in pull request #2352: HIVE-25201: Remove Caffein shading from Iceberg
Posted by GitBox <gi...@apache.org>.
marton-bod commented on a change in pull request #2352:
URL: https://github.com/apache/hive/pull/2352#discussion_r645550217
##########
File path: iceberg/iceberg-shading/pom.xml
##########
@@ -121,7 +117,6 @@
<include>org.apache.parquet:*</include>
<include>com.google*:*</include>
<include>com.fasterxml*:*</include>
- <include>com.github.ben-manes*:*</include>
Review comment:
Are we sure we want to remove it from the fat jar? will the engines be able to get the classes from somewhere else?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org