You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "CodePrometheus (via GitHub)" <gi...@apache.org> on 2024/03/20 00:46:16 UTC
[PR] Add support trace ignore [skywalking-go]
CodePrometheus opened a new pull request, #177:
URL: https://github.com/apache/skywalking-go/pull/177
### Summary
If the operation name of the first span is matching, this segment should be ignored.(multiple split by ","), matching rules follow Ant Path match style, like /path/*, /path/**, /path/?.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support trace ignore [skywalking-go]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #177:
URL: https://github.com/apache/skywalking-go/pull/177#discussion_r1531403406
##########
docs/en/agent/tracing-metrics-logging.md:
##########
@@ -22,10 +22,11 @@ If you wish to disable a particular plugin to prevent enhancements related to th
The basic configuration is as follows:
-| Name | Environment Key | Default Value | Description |
-|---------------------|------------------------|--------------------------------------------------------------|--------------------------------------------------------------------------------------------------------------------------|
-| agent.sampler | SW_AGENT_SAMPLER | 1 | Sampling rate of tracing data, which is a floating-point value that must be between 0 and 1. |
-| agent.ignore_suffix | SW_AGENT_IGNORE_SUFFIX | .jpg,.jpeg,.js,.css,.png,.bmp,.gif,.ico,.mp3,.mp4,.html,.svg | If the operation name of the first span is included in this set, this segment should be ignored.(multiple split by ","). |
+| Name | Environment Key | Default Value | Description |
+|-------------------------|----------------------------|--------------------------------------------------------------|--------------------------------------------------------------------------------------------------------------------------|
+| agent.sampler | SW_AGENT_SAMPLER | 1 | Sampling rate of tracing data, which is a floating-point value that must be between 0 and 1. |
+| agent.ignore_suffix | SW_AGENT_IGNORE_SUFFIX | .jpg,.jpeg,.js,.css,.png,.bmp,.gif,.ico,.mp3,.mp4,.html,.svg | If the operation name of the first span is included in this set, this segment should be ignored.(multiple split by ","). |
+| agent.trace_ignore_path | SW_AGENT_TRACE_IGNORE_PATH | | If the operation name of the first span is matching, this segment should be ignored.(multiple split by ","). |
Review Comment:
If the entry span(first span) of the segment is `GET:/ABC`, in theory, when I set `agent.ignore_suffix=GET:/ABC`, what will happen?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support trace ignore [skywalking-go]
Posted by "CodePrometheus (via GitHub)" <gi...@apache.org>.
CodePrometheus commented on code in PR #177:
URL: https://github.com/apache/skywalking-go/pull/177#discussion_r1534154747
##########
plugins/core/tracer_ignore.go:
##########
@@ -0,0 +1,133 @@
+// Licensed to Apache Software Foundation (ASF) under one or more contributor
+// license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright
+// ownership. Apache Software Foundation (ASF) licenses this file to you under
+// the Apache License, Version 2.0 (the "License"); you may
+// not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package core
+
+import (
+ "strings"
+)
+
+func tracerIgnore(operationName string, ignoreSuffixList, ignorePath []string) bool {
+ return ignoreSuffix(operationName, ignoreSuffixList) || traceIgnorePath(operationName, ignorePath)
+}
+
+func ignoreSuffix(operationName string, ignoreSuffix []string) bool {
+ suffixIdx := strings.LastIndex(operationName, ".")
+ if suffixIdx == -1 {
+ return false
+ }
+ for _, suffix := range ignoreSuffix {
+ if suffix == operationName[suffixIdx:] {
+ return true
+ }
+ }
+ return false
+}
+
+func traceIgnorePath(operationName string, ignorePath []string) bool {
+ for _, pattern := range ignorePath {
+ if normalMatch(pattern, 0, operationName, 0) {
+ return true
+ }
+ }
+ return false
+}
+
+func normalMatch(pat string, p int, str string, s int) bool {
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support trace ignore [skywalking-go]
Posted by "mrproliu (via GitHub)" <gi...@apache.org>.
mrproliu commented on code in PR #177:
URL: https://github.com/apache/skywalking-go/pull/177#discussion_r1532282160
##########
plugins/core/tracer_ignore.go:
##########
@@ -0,0 +1,144 @@
+// Licensed to Apache Software Foundation (ASF) under one or more contributor
+// license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright
+// ownership. Apache Software Foundation (ASF) licenses this file to you under
+// the Apache License, Version 2.0 (the "License"); you may
+// not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package core
+
+import (
+ "strings"
+)
+
+const (
+ PERIOD = "."
+ COLON = ":"
+)
+
+func tracerIgnore(operationName string, ignoreSuffixList []string, ignorePath []string) bool {
+ return ignoreSuffix(operationName, ignoreSuffixList) || traceIgnorePath(operationName, ignorePath)
+}
+
+func ignoreSuffix(operationName string, ignoreSuffix []string) bool {
+ suffixIdx := strings.LastIndex(operationName, PERIOD)
+ if suffixIdx == -1 {
+ return false
+ }
+ for _, suffix := range ignoreSuffix {
+ if suffix == operationName[suffixIdx:] {
+ return true
+ }
+ }
+ return false
+}
+
+func traceIgnorePath(operationName string, ignorePath []string) bool {
+ op := strings.Index(operationName, COLON)
Review Comment:
Nope, I mean why the operation name must-have `:`? Not all operation names contain this symbol. It could make users confused as to why It does not work for other span names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support trace ignore [skywalking-go]
Posted by "CodePrometheus (via GitHub)" <gi...@apache.org>.
CodePrometheus commented on code in PR #177:
URL: https://github.com/apache/skywalking-go/pull/177#discussion_r1532270757
##########
plugins/core/tracer_ignore.go:
##########
@@ -0,0 +1,144 @@
+// Licensed to Apache Software Foundation (ASF) under one or more contributor
+// license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright
+// ownership. Apache Software Foundation (ASF) licenses this file to you under
+// the Apache License, Version 2.0 (the "License"); you may
+// not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package core
+
+import (
+ "strings"
+)
+
+const (
+ PERIOD = "."
+ COLON = ":"
+)
+
+func tracerIgnore(operationName string, ignoreSuffixList []string, ignorePath []string) bool {
+ return ignoreSuffix(operationName, ignoreSuffixList) || traceIgnorePath(operationName, ignorePath)
+}
+
+func ignoreSuffix(operationName string, ignoreSuffix []string) bool {
+ suffixIdx := strings.LastIndex(operationName, PERIOD)
+ if suffixIdx == -1 {
+ return false
+ }
+ for _, suffix := range ignoreSuffix {
+ if suffix == operationName[suffixIdx:] {
+ return true
+ }
+ }
+ return false
+}
+
+func traceIgnorePath(operationName string, ignorePath []string) bool {
+ op := strings.Index(operationName, COLON)
Review Comment:
Are you referring to the occurrence of an empty value for operationName? I'm currently conducting validation based on the operationName dimension.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support trace ignore [skywalking-go]
Posted by "CodePrometheus (via GitHub)" <gi...@apache.org>.
CodePrometheus commented on code in PR #177:
URL: https://github.com/apache/skywalking-go/pull/177#discussion_r1532370144
##########
docs/en/agent/tracing-metrics-logging.md:
##########
@@ -22,10 +22,11 @@ If you wish to disable a particular plugin to prevent enhancements related to th
The basic configuration is as follows:
-| Name | Environment Key | Default Value | Description |
-|---------------------|------------------------|--------------------------------------------------------------|--------------------------------------------------------------------------------------------------------------------------|
-| agent.sampler | SW_AGENT_SAMPLER | 1 | Sampling rate of tracing data, which is a floating-point value that must be between 0 and 1. |
-| agent.ignore_suffix | SW_AGENT_IGNORE_SUFFIX | .jpg,.jpeg,.js,.css,.png,.bmp,.gif,.ico,.mp3,.mp4,.html,.svg | If the operation name of the first span is included in this set, this segment should be ignored.(multiple split by ","). |
+| Name | Environment Key | Default Value | Description |
+|-------------------------|----------------------------|--------------------------------------------------------------|--------------------------------------------------------------------------------------------------------------------------|
+| agent.sampler | SW_AGENT_SAMPLER | 1 | Sampling rate of tracing data, which is a floating-point value that must be between 0 and 1. |
+| agent.ignore_suffix | SW_AGENT_IGNORE_SUFFIX | .jpg,.jpeg,.js,.css,.png,.bmp,.gif,.ico,.mp3,.mp4,.html,.svg | If the operation name of the first span is included in this set, this segment should be ignored.(multiple split by ","). |
+| agent.trace_ignore_path | SW_AGENT_TRACE_IGNORE_PATH | | If the operation name of the first span is matching, this segment should be ignored.(multiple split by ","). |
Review Comment:
Done.
##########
tools/go-agent/config/agent.default.yaml:
##########
@@ -30,8 +30,11 @@ agent:
correlation:
max_key_count: ${SW_AGENT_CORRELATION_MAX_KEY_COUNT:3}
max_value_size: ${SW_AGENT_CORRELATION_MAX_VALUE_SIZE:128}
- # If the operation name of the first span is included in this set, this segment should be ignored.(multiple split by ",")
+ # If the operation name of the first span is included in this set, this segment should be ignored.(multiple split by ",").
ignore_suffix: ${SW_AGENT_IGNORE_SUFFIX:.jpg,.jpeg,.js,.css,.png,.bmp,.gif,.ico,.mp3,.mp4,.html,.svg}
+ # If the operation name of the first span is matching, this segment should be ignored.(multiple split by ",").
+ # Matching rules follow Ant Path match style, like /path/*, /path/**, /path/?.
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support trace ignore [skywalking-go]
Posted by "CodePrometheus (via GitHub)" <gi...@apache.org>.
CodePrometheus commented on code in PR #177:
URL: https://github.com/apache/skywalking-go/pull/177#discussion_r1532270254
##########
docs/en/agent/tracing-metrics-logging.md:
##########
@@ -22,10 +22,11 @@ If you wish to disable a particular plugin to prevent enhancements related to th
The basic configuration is as follows:
-| Name | Environment Key | Default Value | Description |
-|---------------------|------------------------|--------------------------------------------------------------|--------------------------------------------------------------------------------------------------------------------------|
-| agent.sampler | SW_AGENT_SAMPLER | 1 | Sampling rate of tracing data, which is a floating-point value that must be between 0 and 1. |
-| agent.ignore_suffix | SW_AGENT_IGNORE_SUFFIX | .jpg,.jpeg,.js,.css,.png,.bmp,.gif,.ico,.mp3,.mp4,.html,.svg | If the operation name of the first span is included in this set, this segment should be ignored.(multiple split by ","). |
+| Name | Environment Key | Default Value | Description |
+|-------------------------|----------------------------|--------------------------------------------------------------|--------------------------------------------------------------------------------------------------------------------------|
+| agent.sampler | SW_AGENT_SAMPLER | 1 | Sampling rate of tracing data, which is a floating-point value that must be between 0 and 1. |
+| agent.ignore_suffix | SW_AGENT_IGNORE_SUFFIX | .jpg,.jpeg,.js,.css,.png,.bmp,.gif,.ico,.mp3,.mp4,.html,.svg | If the operation name of the first span is included in this set, this segment should be ignored.(multiple split by ","). |
+| agent.trace_ignore_path | SW_AGENT_TRACE_IGNORE_PATH | | If the operation name of the first span is matching, this segment should be ignored.(multiple split by ","). |
Review Comment:
`ignore_suffix` is currently split according to `.` to get the suffix for matching, so `GET:/ABC` will not be filtered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support trace ignore [skywalking-go]
Posted by "CodePrometheus (via GitHub)" <gi...@apache.org>.
CodePrometheus commented on code in PR #177:
URL: https://github.com/apache/skywalking-go/pull/177#discussion_r1532299323
##########
plugins/core/tracer_ignore.go:
##########
@@ -0,0 +1,144 @@
+// Licensed to Apache Software Foundation (ASF) under one or more contributor
+// license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright
+// ownership. Apache Software Foundation (ASF) licenses this file to you under
+// the Apache License, Version 2.0 (the "License"); you may
+// not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package core
+
+import (
+ "strings"
+)
+
+const (
+ PERIOD = "."
+ COLON = ":"
+)
+
+func tracerIgnore(operationName string, ignoreSuffixList []string, ignorePath []string) bool {
+ return ignoreSuffix(operationName, ignoreSuffixList) || traceIgnorePath(operationName, ignorePath)
+}
+
+func ignoreSuffix(operationName string, ignoreSuffix []string) bool {
+ suffixIdx := strings.LastIndex(operationName, PERIOD)
+ if suffixIdx == -1 {
+ return false
+ }
+ for _, suffix := range ignoreSuffix {
+ if suffix == operationName[suffixIdx:] {
+ return true
+ }
+ }
+ return false
+}
+
+func traceIgnorePath(operationName string, ignorePath []string) bool {
+ op := strings.Index(operationName, COLON)
Review Comment:
I did overlook this issue and was only considering web requests before, I will adjust my strategy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support trace ignore [skywalking-go]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #177:
URL: https://github.com/apache/skywalking-go/pull/177
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support trace ignore [skywalking-go]
Posted by "mrproliu (via GitHub)" <gi...@apache.org>.
mrproliu commented on code in PR #177:
URL: https://github.com/apache/skywalking-go/pull/177#discussion_r1531417175
##########
tools/go-agent/config/agent.default.yaml:
##########
@@ -30,8 +30,11 @@ agent:
correlation:
max_key_count: ${SW_AGENT_CORRELATION_MAX_KEY_COUNT:3}
max_value_size: ${SW_AGENT_CORRELATION_MAX_VALUE_SIZE:128}
- # If the operation name of the first span is included in this set, this segment should be ignored.(multiple split by ",")
+ # If the operation name of the first span is included in this set, this segment should be ignored.(multiple split by ",").
ignore_suffix: ${SW_AGENT_IGNORE_SUFFIX:.jpg,.jpeg,.js,.css,.png,.bmp,.gif,.ico,.mp3,.mp4,.html,.svg}
+ # If the operation name of the first span is matching, this segment should be ignored.(multiple split by ",").
+ # Matching rules follow Ant Path match style, like /path/*, /path/**, /path/?.
Review Comment:
Please add more comments about when the user should use `*`, `**`, or `?`.
##########
plugins/core/tracer_ignore.go:
##########
@@ -0,0 +1,144 @@
+// Licensed to Apache Software Foundation (ASF) under one or more contributor
+// license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright
+// ownership. Apache Software Foundation (ASF) licenses this file to you under
+// the Apache License, Version 2.0 (the "License"); you may
+// not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package core
+
+import (
+ "strings"
+)
+
+const (
+ PERIOD = "."
+ COLON = ":"
+)
+
+func tracerIgnore(operationName string, ignoreSuffixList []string, ignorePath []string) bool {
+ return ignoreSuffix(operationName, ignoreSuffixList) || traceIgnorePath(operationName, ignorePath)
+}
+
+func ignoreSuffix(operationName string, ignoreSuffix []string) bool {
+ suffixIdx := strings.LastIndex(operationName, PERIOD)
+ if suffixIdx == -1 {
+ return false
+ }
+ for _, suffix := range ignoreSuffix {
+ if suffix == operationName[suffixIdx:] {
+ return true
+ }
+ }
+ return false
+}
+
+func traceIgnorePath(operationName string, ignorePath []string) bool {
+ op := strings.Index(operationName, COLON)
Review Comment:
Why need to check the operation name must-have :, if the operation is generated by another RPC framework(not HTTP), then this configuration will be broken.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support trace ignore [skywalking-go]
Posted by "mrproliu (via GitHub)" <gi...@apache.org>.
mrproliu commented on code in PR #177:
URL: https://github.com/apache/skywalking-go/pull/177#discussion_r1533170163
##########
plugins/core/tracer_ignore.go:
##########
@@ -0,0 +1,133 @@
+// Licensed to Apache Software Foundation (ASF) under one or more contributor
+// license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright
+// ownership. Apache Software Foundation (ASF) licenses this file to you under
+// the Apache License, Version 2.0 (the "License"); you may
+// not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package core
+
+import (
+ "strings"
+)
+
+func tracerIgnore(operationName string, ignoreSuffixList, ignorePath []string) bool {
+ return ignoreSuffix(operationName, ignoreSuffixList) || traceIgnorePath(operationName, ignorePath)
+}
+
+func ignoreSuffix(operationName string, ignoreSuffix []string) bool {
+ suffixIdx := strings.LastIndex(operationName, ".")
+ if suffixIdx == -1 {
+ return false
+ }
+ for _, suffix := range ignoreSuffix {
+ if suffix == operationName[suffixIdx:] {
+ return true
+ }
+ }
+ return false
+}
+
+func traceIgnorePath(operationName string, ignorePath []string) bool {
+ for _, pattern := range ignorePath {
+ if normalMatch(pattern, 0, operationName, 0) {
+ return true
+ }
+ }
+ return false
+}
+
+func normalMatch(pat string, p int, str string, s int) bool {
Review Comment:
Can you add more comments to the parameters? This can help developers better understand your code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support trace ignore [skywalking-go]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #177:
URL: https://github.com/apache/skywalking-go/pull/177#discussion_r1532279572
##########
docs/en/agent/tracing-metrics-logging.md:
##########
@@ -22,10 +22,11 @@ If you wish to disable a particular plugin to prevent enhancements related to th
The basic configuration is as follows:
-| Name | Environment Key | Default Value | Description |
-|---------------------|------------------------|--------------------------------------------------------------|--------------------------------------------------------------------------------------------------------------------------|
-| agent.sampler | SW_AGENT_SAMPLER | 1 | Sampling rate of tracing data, which is a floating-point value that must be between 0 and 1. |
-| agent.ignore_suffix | SW_AGENT_IGNORE_SUFFIX | .jpg,.jpeg,.js,.css,.png,.bmp,.gif,.ico,.mp3,.mp4,.html,.svg | If the operation name of the first span is included in this set, this segment should be ignored.(multiple split by ","). |
+| Name | Environment Key | Default Value | Description |
+|-------------------------|----------------------------|--------------------------------------------------------------|--------------------------------------------------------------------------------------------------------------------------|
+| agent.sampler | SW_AGENT_SAMPLER | 1 | Sampling rate of tracing data, which is a floating-point value that must be between 0 and 1. |
+| agent.ignore_suffix | SW_AGENT_IGNORE_SUFFIX | .jpg,.jpeg,.js,.css,.png,.bmp,.gif,.ico,.mp3,.mp4,.html,.svg | If the operation name of the first span is included in this set, this segment should be ignored.(multiple split by ","). |
+| agent.trace_ignore_path | SW_AGENT_TRACE_IGNORE_PATH | | If the operation name of the first span is matching, this segment should be ignored.(multiple split by ","). |
Review Comment:
I see. Could you add this to the doc? Because in the Java agent, it is using `endOf` only, so, actually, it could use for complete match filter, although we don't recommend it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support trace ignore [skywalking-go]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #177:
URL: https://github.com/apache/skywalking-go/pull/177#issuecomment-2008474913
> matching rules follow Ant Path match style, like /path/*, /path/**, /path/?.
Is this a question or something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org