You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/05/19 23:22:19 UTC

[GitHub] [incubator-nuttx] hartmannathan commented on pull request #1079: nxstyle: Fix distinction be source and header file for long lines.

hartmannathan commented on pull request #1079:
URL: https://github.com/apache/incubator-nuttx/pull/1079#issuecomment-631138388


   > It is sad to me that the code has become less readable and information has been removed to accommodate the line length. I took pride in following your tradition of reflecting the datasheets in the headers.
   
   I think that can still be done: In earlier conversations, it was agreed that nxstyle would decide what is a "long" line by looking at the length of `/***********` at the top of the file. So, the solution for arch headers is to have a longer header, to allow for readability while also having important register/bit information on the same line as the defines.
   
   Readability **_is_** important, so I hope the above is correct.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org