You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tez.apache.org by bi...@apache.org on 2013/09/04 01:01:47 UTC

git commit: TEZ-301. Running task count in DAG Progress is always 0 ( even as tasks complete ).joeyli via bikas)

Updated Branches:
  refs/heads/master e1ed31b07 -> 92f458b9a


TEZ-301. Running task count in DAG Progress is always 0 ( even as tasks complete ).joeyli via bikas)


Project: http://git-wip-us.apache.org/repos/asf/incubator-tez/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-tez/commit/92f458b9
Tree: http://git-wip-us.apache.org/repos/asf/incubator-tez/tree/92f458b9
Diff: http://git-wip-us.apache.org/repos/asf/incubator-tez/diff/92f458b9

Branch: refs/heads/master
Commit: 92f458b9acb775e4a5a63578f8c302e6e17b5521
Parents: e1ed31b
Author: Bikas Saha <bi...@apache.org>
Authored: Tue Sep 3 16:00:36 2013 -0700
Committer: Bikas Saha <bi...@apache.org>
Committed: Tue Sep 3 16:00:36 2013 -0700

----------------------------------------------------------------------
 .../java/org/apache/tez/dag/app/dag/Vertex.java    |  1 +
 .../apache/tez/dag/app/dag/impl/VertexImpl.java    | 17 ++++++++++++++++-
 2 files changed, 17 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-tez/blob/92f458b9/tez-dag/src/main/java/org/apache/tez/dag/app/dag/Vertex.java
----------------------------------------------------------------------
diff --git a/tez-dag/src/main/java/org/apache/tez/dag/app/dag/Vertex.java b/tez-dag/src/main/java/org/apache/tez/dag/app/dag/Vertex.java
index a33ab91..6992cab 100644
--- a/tez-dag/src/main/java/org/apache/tez/dag/app/dag/Vertex.java
+++ b/tez-dag/src/main/java/org/apache/tez/dag/app/dag/Vertex.java
@@ -61,6 +61,7 @@ public interface Vertex extends Comparable<Vertex> {
   int getTotalTasks();
   int getCompletedTasks();
   int getSucceededTasks();
+  int getRunningTasks();
   float getProgress();
   ProgressBuilder getVertexProgress();
   VertexStatusBuilder getVertexStatus();

http://git-wip-us.apache.org/repos/asf/incubator-tez/blob/92f458b9/tez-dag/src/main/java/org/apache/tez/dag/app/dag/impl/VertexImpl.java
----------------------------------------------------------------------
diff --git a/tez-dag/src/main/java/org/apache/tez/dag/app/dag/impl/VertexImpl.java b/tez-dag/src/main/java/org/apache/tez/dag/app/dag/impl/VertexImpl.java
index b20ac2a..ecd9a5e 100644
--- a/tez-dag/src/main/java/org/apache/tez/dag/app/dag/impl/VertexImpl.java
+++ b/tez-dag/src/main/java/org/apache/tez/dag/app/dag/impl/VertexImpl.java
@@ -482,6 +482,21 @@ public class VertexImpl implements org.apache.tez.dag.app.dag.Vertex,
   }
 
   @Override
+  public int getRunningTasks() {
+    readLock.lock();
+    try {
+      int num=0;
+      for (Task task : tasks.values()) {
+        if(task.getState() == TaskState.RUNNING)
+          num++;
+      }
+      return num;
+    } finally {
+      readLock.unlock();
+    }
+  }
+
+  @Override
   public TezCounters getAllCounters() {
 
     readLock.lock();
@@ -564,7 +579,7 @@ public class VertexImpl implements org.apache.tez.dag.app.dag.Vertex,
       ProgressBuilder progress = new ProgressBuilder();
       progress.setTotalTaskCount(numTasks);
       progress.setSucceededTaskCount(succeededTaskCount);
-      progress.setRunningTaskCount(0); // TODO TEZ-130
+      progress.setRunningTaskCount(getRunningTasks());
       progress.setFailedTaskCount(failedTaskCount);
       progress.setKilledTaskCount(killedTaskCount);
       return progress;