You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/29 11:15:36 UTC

[GitHub] [arrow-rs] nevi-me commented on pull request #2214: CI: Only run coverage jobs on master

nevi-me commented on PR #2214:
URL: https://github.com/apache/arrow-rs/pull/2214#issuecomment-1199159735

   > > Won't this mean we lose information about test coverage in PRs?
   > 
   > Yes that is correct.
   > 
   > @nevi-me @HaoYang670 @jhorstmann @viirya @sunchao do you ever use the per PR code coverage report ? I am proposing to only run coverage jobs on master to improve our CI
   
   An alternative could be to run coverage as part of tests, via `cargo--llvm-cov`, which should also be faster. I'll make changes and PR them into this PR so we can discuss it.
   
   I locally use `llvm-cov` so I do benefit from Rust coverage, but I'm inactive on arrow-rs at the moment, and would be fine if the decision was to disable coverage altogether if it isn't being used.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org