You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2016/09/05 10:19:32 UTC
[GitHub] flink pull request #2473: [FLINK-4580] [rpc] Verify that the rpc endpoint su...
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/2473
[FLINK-4580] [rpc] Verify that the rpc endpoint supports the rpc gateway at connect time
When calling RpcService.connect it is checked that the rpc endpoint supports the specified
rpc gateway. If not, then a RpcConnectionException is thrown. The verification is implemented
as an additional message following after the Identify message. The reason for this is that
the ActorSystem won't wait for the Identify message to time out after it has determined that
the specified actor does not exist. For user-level messages this seems to be not the case and,
thus, we would have to wait for the timeout.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink addGatewayEndpointCheck
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2473.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2473
----
commit 189fb14ddf30726f537f681e800c111ba9bc7c81
Author: Till Rohrmann <tr...@apache.org>
Date: 2016-09-05T10:13:29Z
[FLINK-4580] [rpc] Verify that the rpc endpoint supports the rpc gateway at connect time
When calling RpcService.connect it is checked that the rpc endpoint supports the specified
rpc gateway. If not, then a RpcConnectionException is thrown. The verification is implemented
as an additional message following after the Identify message. The reason for this is that
the ActorSystem won't wait for the Identify message to time out after it has determined that
the specified actor does not exist. For user-level messages this seems to be not the case and,
thus, we would have to wait for the timeout.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2473: [FLINK-4580] [rpc] Verify that the rpc endpoint supports ...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2473
Yes agreed. One will always eventually find out about a wrongly connected rpc endpoint if we introduce a proper error reporting in case of a method lookup/invocation failure.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2473: [FLINK-4580] [rpc] Verify that the rpc endpoint su...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann closed the pull request at:
https://github.com/apache/flink/pull/2473
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2473: [FLINK-4580] [rpc] Verify that the rpc endpoint supports ...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2473
The idea is nice, but it comes at the cost of yet another message roundtrip at startup.
Since we should anyways forward the target endpoint invocation failures to the source gateway, I think that should improve the failure handling in a similar way.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---