You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/23 04:43:43 UTC

[GitHub] [arrow] siddhantrao23 commented on a change in pull request #12340: ARROW-14502: [C++][Gandiva] Add test DayOfMonth

siddhantrao23 commented on a change in pull request #12340:
URL: https://github.com/apache/arrow/pull/12340#discussion_r832842106



##########
File path: cpp/src/gandiva/tests/projector_test.cc
##########
@@ -1975,6 +1975,42 @@ TEST_F(TestProjector, TestCastNullableIntYearInterval) {
   EXPECT_ARROW_ARRAY_EQUALS(out_int64, outputs.at(1));
 }
 
+TEST_F(TestProjector, TestDayOfMonth) {
+  // schema for input fields
+  auto field0 = field("f0", arrow::date64());
+  auto schema = arrow::schema({field0});
+
+  // output fields
+  auto field_result = field("DAY", arrow::int64());

Review comment:
       Could the field name be made lower case here for consistency?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org