You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/02/02 15:13:54 UTC
[GitHub] [incubator-apisix] sshniro opened a new pull request #1102: Batch
processor util to process the logs in batches
sshniro opened a new pull request #1102: Batch processor util to process the logs in batches
URL: https://github.com/apache/incubator-apisix/pull/1102
The following is inspired by the following [batch processor util](https://github.com/Kong/kong/blob/master/kong/tools/batch_queue.lua) implementation (Apache 2) and includes the modifications to the source file.
- Renamed Queue to Batch_Processor
- Added comprehensive test cases covering the edge case scenarios
- Refactored to parallel process the batch instead of appending the failed items as the last element of the array
- Converted the logs to use the core logging module
- Introduced an additional attribute(name) to the batch processor and enhanced the logging by appending the processor name to the logs to exactly identify the failed processes.
- Fixed the wrong assertion for [process_delay](https://github.com/Kong/kong/blob/619de297b0a68769bd38cff49f7810030851b550/kong/tools/batch_queue.lua#L234) in the original source file
- Renamed the following variables(batch_size => batch_max_size, retries => retry_count, batch_queue => batch_to_process )
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] sshniro closed pull request #1102: Batch
processor util to process the logs in batches
Posted by GitBox <gi...@apache.org>.
sshniro closed pull request #1102: Batch processor util to process the logs in batches
URL: https://github.com/apache/incubator-apisix/pull/1102
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] sshniro commented on issue #1102: Batch
processor util to process the logs in batches
Posted by GitBox <gi...@apache.org>.
sshniro commented on issue #1102: Batch processor util to process the logs in batches
URL: https://github.com/apache/incubator-apisix/pull/1102#issuecomment-581743110
Sure. Will do.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] membphis commented on issue #1102: Batch
processor util to process the logs in batches
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #1102: Batch processor util to process the logs in batches
URL: https://github.com/apache/incubator-apisix/pull/1102#issuecomment-581724972
@sshniro we can not copy the source code directly from aother project, you need to rewrite it again.
and need to add some doc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services