You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "hililiwei (via GitHub)" <gi...@apache.org> on 2023/02/11 03:38:07 UTC
[GitHub] [iceberg] hililiwei opened a new pull request, #6807: Spark 3.3: SQL Extensions for DROP TAG
hililiwei opened a new pull request, #6807:
URL: https://github.com/apache/iceberg/pull/6807
Co-authored-by: Amogh Jahagirdar <ja...@amazon.com>
Co-authored-by: chidayong <24...@qq.com>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] hililiwei commented on pull request #6807: Spark 3.3: SQL Extensions for DROP TAG
Posted by "hililiwei (via GitHub)" <gi...@apache.org>.
hililiwei commented on PR #6807:
URL: https://github.com/apache/iceberg/pull/6807#issuecomment-1430815671
Thank you all for review 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 merged pull request #6807: Spark 3.3: SQL Extensions for DROP TAG
Posted by "jackye1995 (via GitHub)" <gi...@apache.org>.
jackye1995 merged PR #6807:
URL: https://github.com/apache/iceberg/pull/6807
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] singhpk234 commented on a diff in pull request #6807: Spark 3.3: SQL Extensions for DROP TAG
Posted by "singhpk234 (via GitHub)" <gi...@apache.org>.
singhpk234 commented on code in PR #6807:
URL: https://github.com/apache/iceberg/pull/6807#discussion_r1106330792
##########
spark/v3.3/spark-extensions/src/main/antlr/org.apache.spark.sql.catalyst.parser.extensions/IcebergSqlExtensions.g4:
##########
@@ -76,6 +76,7 @@ statement
| ALTER TABLE multipartIdentifier createReplaceBranchClause #createOrReplaceBranch
| ALTER TABLE multipartIdentifier createReplaceTagClause #createOrReplaceTag
| ALTER TABLE multipartIdentifier DROP BRANCH (IF EXISTS)? identifier #dropBranch
+ | ALTER TABLE multipartIdentifier DROP TAG (IF EXISTS)? identifier #dropTag
Review Comment:
I see, was mostly coming from spark code base, considering this example :
https://github.com/apache/spark/blob/46a234125d3f125ba1f9ccd6af0ec1ba61016c1e/sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4#L125
If we have reached the concencus, then it should be fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on a diff in pull request #6807: Spark 3.3: SQL Extensions for DROP TAG
Posted by "jackye1995 (via GitHub)" <gi...@apache.org>.
jackye1995 commented on code in PR #6807:
URL: https://github.com/apache/iceberg/pull/6807#discussion_r1106001997
##########
spark/v3.3/spark-extensions/src/main/antlr/org.apache.spark.sql.catalyst.parser.extensions/IcebergSqlExtensions.g4:
##########
@@ -76,6 +76,7 @@ statement
| ALTER TABLE multipartIdentifier createReplaceBranchClause #createOrReplaceBranch
| ALTER TABLE multipartIdentifier createReplaceTagClause #createOrReplaceTag
| ALTER TABLE multipartIdentifier DROP BRANCH (IF EXISTS)? identifier #dropBranch
+ | ALTER TABLE multipartIdentifier DROP TAG (IF EXISTS)? identifier #dropTag
Review Comment:
we discussed this in https://github.com/apache/iceberg/pull/6637#discussion_r1083330167, and the conclusion was that it makes the logic a bit more consistent with CREATE to have them separated. Let me know what you think!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] singhpk234 commented on a diff in pull request #6807: Spark 3.3: SQL Extensions for DROP TAG
Posted by "singhpk234 (via GitHub)" <gi...@apache.org>.
singhpk234 commented on code in PR #6807:
URL: https://github.com/apache/iceberg/pull/6807#discussion_r1105316294
##########
spark/v3.3/spark-extensions/src/main/antlr/org.apache.spark.sql.catalyst.parser.extensions/IcebergSqlExtensions.g4:
##########
@@ -76,6 +76,7 @@ statement
| ALTER TABLE multipartIdentifier createReplaceBranchClause #createOrReplaceBranch
| ALTER TABLE multipartIdentifier createReplaceTagClause #createOrReplaceTag
| ALTER TABLE multipartIdentifier DROP BRANCH (IF EXISTS)? identifier #dropBranch
+ | ALTER TABLE multipartIdentifier DROP TAG (IF EXISTS)? identifier #dropTag
Review Comment:
can this be written like :
```suggestion
| ALTER TABLE multipartIdentifier DROP (BRANCH | TAG) (IF EXISTS)? identifier #dropBranchOrTag
```
##########
spark/v3.3/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/DropTag.scala:
##########
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.spark.sql.catalyst.plans.logical
+
+import org.apache.spark.sql.catalyst.expressions.Attribute
+
+case class DropTag(table: Seq[String], tag: String, ifExists: Boolean) extends LeafCommand {
+
+ import org.apache.spark.sql.connector.catalog.CatalogV2Implicits._
+
+ override lazy val output: Seq[Attribute] = Nil
+
+ override def simpleString(maxFields: Int): String = {
+ s"DropTag tag: ${tag} for tag: ${table.quoted}"
Review Comment:
```suggestion
s"DropTag tag: ${tag} for table: ${table.quoted}"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on a diff in pull request #6807: Spark 3.3: SQL Extensions for DROP TAG
Posted by "jackye1995 (via GitHub)" <gi...@apache.org>.
jackye1995 commented on code in PR #6807:
URL: https://github.com/apache/iceberg/pull/6807#discussion_r1106001997
##########
spark/v3.3/spark-extensions/src/main/antlr/org.apache.spark.sql.catalyst.parser.extensions/IcebergSqlExtensions.g4:
##########
@@ -76,6 +76,7 @@ statement
| ALTER TABLE multipartIdentifier createReplaceBranchClause #createOrReplaceBranch
| ALTER TABLE multipartIdentifier createReplaceTagClause #createOrReplaceTag
| ALTER TABLE multipartIdentifier DROP BRANCH (IF EXISTS)? identifier #dropBranch
+ | ALTER TABLE multipartIdentifier DROP TAG (IF EXISTS)? identifier #dropTag
Review Comment:
I think we discussed this in https://github.com/apache/iceberg/pull/6637#discussion_r1083330167, and the conclusion was that it makes the logic a bit more consistent with CREATE to have them separated. Let me know what you think!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on a diff in pull request #6807: Spark 3.3: SQL Extensions for DROP TAG
Posted by "jackye1995 (via GitHub)" <gi...@apache.org>.
jackye1995 commented on code in PR #6807:
URL: https://github.com/apache/iceberg/pull/6807#discussion_r1106001997
##########
spark/v3.3/spark-extensions/src/main/antlr/org.apache.spark.sql.catalyst.parser.extensions/IcebergSqlExtensions.g4:
##########
@@ -76,6 +76,7 @@ statement
| ALTER TABLE multipartIdentifier createReplaceBranchClause #createOrReplaceBranch
| ALTER TABLE multipartIdentifier createReplaceTagClause #createOrReplaceTag
| ALTER TABLE multipartIdentifier DROP BRANCH (IF EXISTS)? identifier #dropBranch
+ | ALTER TABLE multipartIdentifier DROP TAG (IF EXISTS)? identifier #dropTag
Review Comment:
we discussed this in https://github.com/apache/iceberg/pull/6637#discussion_r1083330167, and the conclusion was that it is more clear to have them separated.
The current way for separated DROP BRANCH and DROP TAG makes the logic consistent with CREATE.
Let me know what you think!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on pull request #6807: Spark 3.3: SQL Extensions for DROP TAG
Posted by "jackye1995 (via GitHub)" <gi...@apache.org>.
jackye1995 commented on PR #6807:
URL: https://github.com/apache/iceberg/pull/6807#issuecomment-1430437688
Looks like we have all comments addressed, I will go ahead to merge the PR. Thanks for the contribution @hililiwei , and thanks for everyone's review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on a diff in pull request #6807: Spark 3.3: SQL Extensions for DROP TAG
Posted by "jackye1995 (via GitHub)" <gi...@apache.org>.
jackye1995 commented on code in PR #6807:
URL: https://github.com/apache/iceberg/pull/6807#discussion_r1104846908
##########
spark/v3.3/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestTagDDL.java:
##########
@@ -264,6 +264,54 @@ public void testCreateOrReplace() throws NoSuchTableException {
Assert.assertEquals(first, ref.snapshotId());
}
+ @Test
+ public void testDropTag() throws NoSuchTableException {
+ insertRows();
+ Table table = validationCatalog.loadTable(tableIdent);
+ String tagName = "t1";
+ table.manageSnapshots().createTag(tagName, table.currentSnapshot().snapshotId()).commit();
+ SnapshotRef ref = table.refs().get(tagName);
+ Assert.assertEquals(table.currentSnapshot().snapshotId(), ref.snapshotId());
+
+ sql("ALTER TABLE %s DROP TAG %s", tableName, tagName);
+ table.refresh();
+ ref = table.refs().get(tagName);
+ Assert.assertNull(ref);
Review Comment:
nit: we should prefer to add a description for all the assertions, there are many `assertNull` here that lack description
##########
spark/v3.3/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestTagDDL.java:
##########
@@ -264,6 +264,54 @@ public void testCreateOrReplace() throws NoSuchTableException {
Assert.assertEquals(first, ref.snapshotId());
}
+ @Test
+ public void testDropTag() throws NoSuchTableException {
+ insertRows();
+ Table table = validationCatalog.loadTable(tableIdent);
+ String tagName = "t1";
+ table.manageSnapshots().createTag(tagName, table.currentSnapshot().snapshotId()).commit();
+ SnapshotRef ref = table.refs().get(tagName);
+ Assert.assertEquals(table.currentSnapshot().snapshotId(), ref.snapshotId());
+
+ sql("ALTER TABLE %s DROP TAG %s", tableName, tagName);
+ table.refresh();
+ ref = table.refs().get(tagName);
+ Assert.assertNull(ref);
Review Comment:
nit: we should prefer to add a description for all the assertions, there are many `assertEquals` and `assertNull` here that lack description
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on a diff in pull request #6807: Spark 3.3: SQL Extensions for DROP TAG
Posted by "jackye1995 (via GitHub)" <gi...@apache.org>.
jackye1995 commented on code in PR #6807:
URL: https://github.com/apache/iceberg/pull/6807#discussion_r1104845643
##########
spark/v3.3/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestTagDDL.java:
##########
@@ -264,6 +264,54 @@ public void testCreateOrReplace() throws NoSuchTableException {
Assert.assertEquals(first, ref.snapshotId());
}
+ @Test
+ public void testDropTag() throws NoSuchTableException {
+ insertRows();
+ Table table = validationCatalog.loadTable(tableIdent);
+ String tagName = "t1";
+ table.manageSnapshots().createTag(tagName, table.currentSnapshot().snapshotId()).commit();
+ SnapshotRef ref = table.refs().get(tagName);
+ Assert.assertEquals(table.currentSnapshot().snapshotId(), ref.snapshotId());
+
+ sql("ALTER TABLE %s DROP TAG %s", tableName, tagName);
+ table.refresh();
+ ref = table.refs().get(tagName);
+ Assert.assertNull(ref);
+
+ AssertHelpers.assertThrows(
+ "Non-conforming tag name",
+ IcebergParseException.class,
+ "mismatched input '123'",
+ () -> sql("ALTER TABLE %s DROP TAG %s", tableName, "123"));
Review Comment:
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] amogh-jahagirdar commented on a diff in pull request #6807: Spark 3.3: SQL Extensions for DROP TAG
Posted by "amogh-jahagirdar (via GitHub)" <gi...@apache.org>.
amogh-jahagirdar commented on code in PR #6807:
URL: https://github.com/apache/iceberg/pull/6807#discussion_r1106353561
##########
spark/v3.3/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestBranchDDL.java:
##########
@@ -238,6 +238,28 @@ public void testDropBranchDoesNotExist() {
() -> sql("ALTER TABLE %s DROP BRANCH %s", tableName, "nonExistingBranch"));
}
+ @Test
+ public void testDropBranchFailesForTag() throws NoSuchTableException {
Review Comment:
```suggestion
public void testDropBranchFailsForTag() throws NoSuchTableException {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on a diff in pull request #6807: Spark 3.3: SQL Extensions for DROP TAG
Posted by "jackye1995 (via GitHub)" <gi...@apache.org>.
jackye1995 commented on code in PR #6807:
URL: https://github.com/apache/iceberg/pull/6807#discussion_r1106001997
##########
spark/v3.3/spark-extensions/src/main/antlr/org.apache.spark.sql.catalyst.parser.extensions/IcebergSqlExtensions.g4:
##########
@@ -76,6 +76,7 @@ statement
| ALTER TABLE multipartIdentifier createReplaceBranchClause #createOrReplaceBranch
| ALTER TABLE multipartIdentifier createReplaceTagClause #createOrReplaceTag
| ALTER TABLE multipartIdentifier DROP BRANCH (IF EXISTS)? identifier #dropBranch
+ | ALTER TABLE multipartIdentifier DROP TAG (IF EXISTS)? identifier #dropTag
Review Comment:
I think we discussed this in https://github.com/apache/iceberg/pull/6637#discussion_r1083330167, and the conclusion was that it makes the logic a bit more consistent to have them separated. Let me know what you think!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on pull request #6807: Spark 3.3: SQL Extensions for DROP TAG
Posted by "jackye1995 (via GitHub)" <gi...@apache.org>.
jackye1995 commented on PR #6807:
URL: https://github.com/apache/iceberg/pull/6807#issuecomment-1428417647
Overall looks good to me, just some nit comments about the tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] amogh-jahagirdar commented on a diff in pull request #6807: Spark 3.3: SQL Extensions for DROP TAG
Posted by "amogh-jahagirdar (via GitHub)" <gi...@apache.org>.
amogh-jahagirdar commented on code in PR #6807:
URL: https://github.com/apache/iceberg/pull/6807#discussion_r1104836737
##########
spark/v3.3/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestTagDDL.java:
##########
@@ -264,6 +264,54 @@ public void testCreateOrReplace() throws NoSuchTableException {
Assert.assertEquals(first, ref.snapshotId());
}
+ @Test
Review Comment:
I think we should also have a test to ensure that DROP TAG does not work when the ref is a branch. If I missed the opposite case for DROP BRANCH, I think let's add that as well for completeness.
##########
spark/v3.3/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestTagDDL.java:
##########
@@ -264,6 +264,54 @@ public void testCreateOrReplace() throws NoSuchTableException {
Assert.assertEquals(first, ref.snapshotId());
}
+ @Test
+ public void testDropTag() throws NoSuchTableException {
+ insertRows();
+ Table table = validationCatalog.loadTable(tableIdent);
+ String tagName = "t1";
+ table.manageSnapshots().createTag(tagName, table.currentSnapshot().snapshotId()).commit();
+ SnapshotRef ref = table.refs().get(tagName);
+ Assert.assertEquals(table.currentSnapshot().snapshotId(), ref.snapshotId());
+
+ sql("ALTER TABLE %s DROP TAG %s", tableName, tagName);
+ table.refresh();
+ ref = table.refs().get(tagName);
+ Assert.assertNull(ref);
+
+ AssertHelpers.assertThrows(
+ "Non-conforming tag name",
+ IcebergParseException.class,
+ "mismatched input '123'",
+ () -> sql("ALTER TABLE %s DROP TAG %s", tableName, "123"));
Review Comment:
I think it's fine to include this test but could we separate it and have this test just focused on the happy case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 closed pull request #6807: Spark 3.3: SQL Extensions for DROP TAG
Posted by "jackye1995 (via GitHub)" <gi...@apache.org>.
jackye1995 closed pull request #6807: Spark 3.3: SQL Extensions for DROP TAG
URL: https://github.com/apache/iceberg/pull/6807
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on pull request #6807: Spark 3.3: SQL Extensions for DROP TAG
Posted by "jackye1995 (via GitHub)" <gi...@apache.org>.
jackye1995 commented on PR #6807:
URL: https://github.com/apache/iceberg/pull/6807#issuecomment-1430039299
Restart CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] amogh-jahagirdar commented on a diff in pull request #6807: Spark 3.3: SQL Extensions for DROP TAG
Posted by "amogh-jahagirdar (via GitHub)" <gi...@apache.org>.
amogh-jahagirdar commented on code in PR #6807:
URL: https://github.com/apache/iceberg/pull/6807#discussion_r1106344659
##########
spark/v3.3/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestBranchDDL.java:
##########
@@ -238,6 +238,28 @@ public void testDropBranchDoesNotExist() {
() -> sql("ALTER TABLE %s DROP BRANCH %s", tableName, "nonExistingBranch"));
}
+ @Test
+ public void testDropBranchFailesForTag() throws NoSuchTableException {
Review Comment:
Just noticed typo: Should be `testDropBranchFailsForTag`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org