[GitHub] [helix] desaikomal commented on a diff in pull request #2456: Code cleanup and improvement in intermediate state calc stage related

["desaikomal (via GitHub)" <gi...@apache.org>]

desaikomal commented on code in PR #2456:
URL: https://github.com/apache/helix/pull/2456#discussion_r1175499600


##########
helix-core/src/main/java/org/apache/helix/controller/stages/StateTransitionThrottleController.java:
##########
@@ -155,16 +136,20 @@ protected boolean shouldThrottleForResource(
    */
   protected boolean shouldThrottleForInstance(
       StateTransitionThrottleConfig.RebalanceType rebalanceType, String instanceName) {
+    return shouldThrottleForGivenMap(rebalanceType, instanceName, _pendingTransitionAllowedPerInstance);

Review Comment:
   Is there a reason why you split this function into 2? Is there any consumer of shouldThrottleForGivenMap() ???



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org