[GitHub] [incubator-nuttx] davids5 commented on pull request #3218: Integration of pysimCoder with NUTTX

[GitBox <gi...@apache.org>]

davids5 commented on pull request #3218:
URL: https://github.com/apache/incubator-nuttx/pull/3218#issuecomment-809319683


   > Hi @robertobucher it is fine now! The warning converted to error was already in the USB Host driver:
   > 
   > ```
   > Error: chip/stm32_usbhost.c:42:33: error: excess elements in array initializer [-Werror]
   >    42 | #define TRENTRY(id,fmt1,string) {string}
   >       |                                 ^
   > chip/stm32_usbhost.c:96:3: note: in expansion of macro 'TRENTRY'
   >    96 |   TRENTRY(OTGHS_TRACE1_TRNSFRFAILED,       TR_FMT1, "OTGHS  ERROR: Transfer Failed. ret=%d\n"),
   >       |   ^~~~~~~
   > chip/stm32_usbhost.c:42:33: note: (near initialization for 'g_trace1')
   >    42 | #define TRENTRY(id,fmt1,string) {string}
   >       |                                 ^
   > chip/stm32_usbhost.c:96:3: note: in expansion of macro 'TRENTRY'
   >    96 |   TRENTRY(OTGHS_TRACE1_TRNSFRFAILED,       TR_FMT1, "OTGHS  ERROR: Transfer Failed. ret=%d\n"),
   >       |   ^~~~~~~
   > ```
   > 
   > @davids5 and @raiden00pl some idea about this issue?
   > 
   > I propose to merge the current PR because it is not the root of the issue and we cannot pass the burden of fixing existent BUGs to new contributors that are already enfforting to make their PR into NuttX.
   
   @acassis What is the value in TRACE1_NSTRINGS?
   
   >I propose to merge the current PR because it is not the root of the issue and we cannot pass the burden of fixing existent BUGs to new contributors that are already enfforting to make their PR into NuttX.
   
   I am not apposed to this, but the, since the CI did not finish we will not know if it break something else. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org