You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "js8544 (via GitHub)" <gi...@apache.org> on 2023/06/28 16:59:28 UTC
[GitHub] [arrow] js8544 commented on a diff in pull request #36358: GH-36345: [C++] Prefer TypeError over Invalid in IsIn and IndexIn kernels
js8544 commented on code in PR #36358:
URL: https://github.com/apache/arrow/pull/36358#discussion_r1245514284
##########
cpp/src/arrow/compute/kernels/scalar_set_lookup.cc:
##########
@@ -326,9 +326,13 @@ struct IndexInVisitor {
const auto& state = checked_cast<const SetLookupState<Type>&>(*ctx->state());
if (!data.type->Equals(state.value_set_type)) {
auto materialized_input = data.ToArrayData();
- ARROW_ASSIGN_OR_RAISE(auto casted_input,
- Cast(*materialized_input, state.value_set_type,
- CastOptions::Safe(), ctx->exec_context()));
+ auto cast_result = Cast(*materialized_input, state.value_set_type,
+ CastOptions::Safe(), ctx->exec_context());
+ if (ARROW_PREDICT_FALSE(!cast_result.ok())) {
Review Comment:
Done.
##########
cpp/src/arrow/compute/kernels/scalar_set_lookup.cc:
##########
@@ -423,11 +427,15 @@ struct IsInVisitor {
const auto& state = checked_cast<const SetLookupState<Type>&>(*ctx->state());
if (!data.type->Equals(state.value_set_type)) {
- auto materialized_data = data.ToArrayData();
- ARROW_ASSIGN_OR_RAISE(auto casted_data,
- Cast(*materialized_data, state.value_set_type,
- CastOptions::Safe(), ctx->exec_context()));
- return ProcessIsIn(state, *casted_data.array());
+ auto materialized_input = data.ToArrayData();
+ auto cast_result = Cast(*materialized_input, state.value_set_type,
+ CastOptions::Safe(), ctx->exec_context());
+ if (ARROW_PREDICT_FALSE(!cast_result.ok())) {
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org