You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by dragon512 <gi...@git.apache.org> on 2016/01/27 21:49:03 UTC
[GitHub] trafficserver pull request: [TS-4157] traffic_via tests use bad ch...
GitHub user dragon512 opened a pull request:
https://github.com/apache/trafficserver/pull/440
[TS-4157] traffic_via tests use bad characters in the file name
Changed the usage of : to ; which seems to be more filename friendly.
Changed test files to have ; in them
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dragon512/trafficserver master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/440.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #440
----
commit 561a80ea57bef2d53b3ffb0d3eff450b6a05bc69
Author: dragon512 <dr...@live.com>
Date: 2016-01-26T21:07:29Z
Update traffic_via.cc
Change use of : to ; as this character is safer to use on shared drives with different OS
commit c1c578fd01838177a9695f358f739f8b44619c0f
Author: Jason Kenny <jk...@yahoo-inc.com>
Date: 2016-01-27T20:30:34Z
changed test files to use ; intsead of :
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: [TS-4157] traffic_via tests use bad ch...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/440#issuecomment-175908728
I don't think you can just change the ':' to a ';'. The ':' is what the Via: header will have, which means, you'd break compatibility. Meaning, it would no longer properly parse the input from a Via: header (I think at least).
One option is to allow the separator to be either ';' or ':', such that the file names can use the ;, whereas the string in the Via: header continues to use ':'.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: [TS-4157] traffic_via tests use bad ch...
Posted by SolidWallOfCode <gi...@git.apache.org>.
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/440#issuecomment-176484446
Ultimately I think you'd just want the values in file, one per line. But that's a bigger fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: [TS-4157] traffic_via tests use bad ch...
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/440#issuecomment-176480821
There is not really a good reason for these tests to store weird names in the filesystem. It just happened to be an easy way to do what I needed at the time. A better solution would be to figure out a way to not need these files in the first place.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: [TS-4157] traffic_via tests use bad ch...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/440
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: [TS-4157] traffic_via tests use bad ch...
Posted by dragon512 <gi...@git.apache.org>.
Github user dragon512 commented on the pull request:
https://github.com/apache/trafficserver/pull/440#issuecomment-176292994
Thanks. I have updated the patch with this fix
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: [TS-4157] traffic_via tests use bad ch...
Posted by dragon512 <gi...@git.apache.org>.
Github user dragon512 commented on the pull request:
https://github.com/apache/trafficserver/pull/440#issuecomment-176508745
I agree with James in that the test are badly written. A better fix would be to use a real testing system. I working on that as well. It would be worse just to fix these tests and not others as this just adds to random chaos that already exists in the source tree of ATS. I am working on presenting a better test setup for ATS ( unit testing and a fix for TSQA), as well as trying to fix the build and source layout. This has to be done correctly and in baby steps with a plan.
However the main fix here was not to fix badly written and apparently rushed tests, but solve use of values that break ATS from being checked out on file systems that don't allow certain values in the file name. This is only a small fix of many we need to clean up ATS infra.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: [TS-4157] traffic_via tests use bad ch...
Posted by meeramn <gi...@git.apache.org>.
Github user meeramn commented on the pull request:
https://github.com/apache/trafficserver/pull/440#issuecomment-176452436
Updated patch looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---