[GitHub] [ratis] szetszwo commented on a diff in pull request #680: RATIS-1622. Fix high CPU load when some followers are down

[GitBox <gi...@apache.org>]

szetszwo commented on code in PR #680:
URL: https://github.com/apache/ratis/pull/680#discussion_r920310850


##########
ratis-grpc/src/main/java/org/apache/ratis/grpc/server/GrpcLogAppender.java:
##########
@@ -158,12 +158,20 @@ public void run() throws IOException {
   public long getWaitTimeMs() {
     if (haveTooManyPendingRequests()) {
       return getHeartbeatWaitTimeMs(); // Should wait for a short time
-    } else if (shouldSendAppendEntries()) {
+    } else if (shouldSendAppendEntries() && !isSlowFollower()) {
+      // For normal nodes, new entries should be sent ASAP
+      // however for slow followers (eapecially when the follower is down),

Review Comment:
   TYPO: eapecially -> especially



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org