You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Hudson (Commented) (JIRA)" <ji...@apache.org> on 2012/01/24 02:07:40 UTC

[jira] [Commented] (TAP5-1801) Component fields should not need to be private, merely non-public

    [ https://issues.apache.org/jira/browse/TAP5-1801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13191716#comment-13191716 ] 

Hudson commented on TAP5-1801:
------------------------------

Integrated in tapestry-5.3-freestyle #4 (See [https://builds.apache.org/job/tapestry-5.3-freestyle/4/])
    Do some backporting work for TAP5-1801 from trunk

mlusetti : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1235046
Files : 
* /tapestry/tapestry5/branches/5.3
* /tapestry/tapestry5/branches/5.3/plastic/src/main/java/org/apache/tapestry5/internal/plastic/FieldInstrumentation.java
* /tapestry/tapestry5/branches/5.3/plastic/src/main/java/org/apache/tapestry5/internal/plastic/FieldInstrumentations.java

                
> Component fields should not need to be private, merely non-public
> -----------------------------------------------------------------
>
>                 Key: TAP5-1801
>                 URL: https://issues.apache.org/jira/browse/TAP5-1801
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: plastic, tapestry-core
>    Affects Versions: 5.4
>            Reporter: Howard M. Lewis Ship
>            Assignee: Howard M. Lewis Ship
>              Labels: bytecode
>             Fix For: 5.3.2, 5.4
>
>
> Currently, Plastic assets, early, that all instance fields are private.  Instead, it should check fields as transformations are applied to them, and ensure that they are merely non-public. Access to the fields from other classes (including inner classes) must be routed through access methods.
> Inner classes will now need a limited set of transformations, to handle the cases where a protected or package private field is directly accessed, in which case, the appropriate accessor method will be used instead.
> It seems possible that two transformed classes that each access the other's non-public fields might cause an endless loop; if so, this should be identified and reported.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira