[jira] [Closed] (TINKERPOP-1058) Make EmptyVertexProperty and EmptyProperty not final

["stephen mallette (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/TINKERPOP-1058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stephen mallette closed TINKERPOP-1058.
---------------------------------------
    Resolution: Won't Do
      Assignee: stephen mallette

TINKERPOP-790 was closed a long time ago. Another related issue that I can't seem to locate also introduce closeable steps on traversals, so when you call close on a {{Traversal}} it will iterate the steps and {{close()}} those. Steps like {{VertexStep}} which open iterators are closeable. They detect {{CloseableIterator}} and attempt to {{close()}} them. That should ultimately release expensive resources that a graph opens. Since users are encouraged to use the Traversal API and not the Graph API they don't need to really get a {{CloseableIterator}} and you could perhaps loosen up the return type again. If not, I would recommend just doing an {{OptOut}} of the failing tests (I think there might only be three of them and they are fairly minor in what they are enforcing for compliance). 

> Make EmptyVertexProperty and EmptyProperty not final
> ----------------------------------------------------
>
>                 Key: TINKERPOP-1058
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1058
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: structure
>    Affects Versions: 3.1.0-incubating, 3.1.1-incubating
>            Reporter: Mike Personick
>            Assignee: stephen mallette
>            Priority: Minor
>
> I would like to be able to extend these classes to make certain tests in the StructureStandardSuite pass without overriding them and changing their logic a bit.   Those tests do things like this:
> assertEquals(VertexProperty.empty(), p);
> Where in my case p is a BlazeVertexProperty (strengthens the return type on any iterators to CloseableIterator), but the equality method on EmptyVertexProperty checks the class of other.  So I'd need to subclass EmptyVertexProperty to make it work.  Of course if we changed the GraphAPI to use CloseableIterators then this change would become unnecessary as I could use the "stock" API instead.  
> Related to:
> https://issues.apache.org/jira/browse/TINKERPOP-790



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)