You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/01/31 16:41:55 UTC
[GitHub] [pulsar-helm-chart] lhotari opened a new pull request #221: [Proxy] Configure metadata settings for Proxy
lhotari opened a new pull request #221:
URL: https://github.com/apache/pulsar-helm-chart/pull/221
### Motivation
- enables service discovery in the proxy
- required by https://github.com/apache/pulsar/pull/14078 changes
### Modifications
- configure `zookeeperServers` and `configurationStoreServers` for the Proxy to enable service discovery
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] lhotari commented on a change in pull request #221: [Proxy] Configure metadata settings for Proxy
Posted by GitBox <gi...@apache.org>.
lhotari commented on a change in pull request #221:
URL: https://github.com/apache/pulsar-helm-chart/pull/221#discussion_r795889617
##########
File path: charts/pulsar/templates/proxy-configmap.yaml
##########
@@ -27,6 +27,15 @@ metadata:
{{- include "pulsar.standardLabels" . | nindent 4 }}
component: {{ .Values.proxy.component }}
data:
+ # Metadata settings
+ zookeeperServers: "{{ template "pulsar.zookeeper.connect" . }}{{ .Values.metadataPrefix }}"
+ {{- if .Values.pulsar_metadata.configurationStore }}
+ configurationStoreServers: "{{ template "pulsar.configurationStore.connect" . }}{{ .Values.pulsar_metadata.configurationStoreMetadataPrefix }}"
+ {{- end }}
+ {{- if not .Values.pulsar_metadata.configurationStore }}
Review comment:
Thanks, that makes sense. I had copy-pasted the original logic from https://github.com/apache/pulsar-helm-chart/blob/dc97bd4ac6ae59610f685341dedd716ed10a8165/charts/pulsar/templates/broker-configmap.yaml#L30-L37
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] michaeljmarshall commented on a change in pull request #221: [Proxy] Configure metadata settings for Proxy
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on a change in pull request #221:
URL: https://github.com/apache/pulsar-helm-chart/pull/221#discussion_r795871113
##########
File path: charts/pulsar/templates/proxy-configmap.yaml
##########
@@ -27,6 +27,15 @@ metadata:
{{- include "pulsar.standardLabels" . | nindent 4 }}
component: {{ .Values.proxy.component }}
data:
+ # Metadata settings
+ zookeeperServers: "{{ template "pulsar.zookeeper.connect" . }}{{ .Values.metadataPrefix }}"
+ {{- if .Values.pulsar_metadata.configurationStore }}
+ configurationStoreServers: "{{ template "pulsar.configurationStore.connect" . }}{{ .Values.pulsar_metadata.configurationStoreMetadataPrefix }}"
+ {{- end }}
+ {{- if not .Values.pulsar_metadata.configurationStore }}
Review comment:
Nit:
```suggestion
{{- else }}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org