You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2022/01/09 08:15:36 UTC
[GitHub] [orc] guiyanakuang opened a new pull request #1003: Fix code in `FileDump` and `JsonFileDump` commands that determines if column statistics exist
guiyanakuang opened a new pull request #1003:
URL: https://github.com/apache/orc/pull/1003
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If there is a discussion in the mailing list, please add the link.
-->
This pr is aims to fixing code in the FileDump and JsonFileDump commands that determines whether a column statistic exists or not.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Before we can get the ColumnStatistics from RowIndex we need to determine whether it exists or not.
`entry.getStatistics()` does not return null at any time, and will return a default object when it is not set.
The current impl is wrong
```java
OrcProto.ColumnStatistics colStats = entry.getStatistics();
if (colStats == null) {
buf.append("no stats at ");
}
```
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Pass the CIs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] guiyanakuang commented on pull request #1003: ORC-1082: Fix code in `FileDump` and `JsonFileDump` commands that determines if column statistics exist
Posted by GitBox <gi...@apache.org>.
guiyanakuang commented on pull request #1003:
URL: https://github.com/apache/orc/pull/1003#issuecomment-1008562661
You are right. Accept criticism :grimacing:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] guiyanakuang commented on pull request #1003: ORC-1082: Fix code in `FileDump` and `JsonFileDump` commands that determines if column statistics exist
Posted by GitBox <gi...@apache.org>.
guiyanakuang commented on pull request #1003:
URL: https://github.com/apache/orc/pull/1003#issuecomment-1008501054
> Thanks. Could you elaborate how to verify your PR in the PR description, @guiyanakuang ?
@dongjoon-hyun This can be tested with the following code
```java
@Test
public void test() {
OrcProto.RowIndexEntry entry = OrcProto.RowIndexEntry.newBuilder().addPositions(0).build();
assertFalse(entry.hasStatistics());
assertNotNull(entry.getStatistics());
}
```
But since this is just testing Protobuf generated code, I'm not sure if I should add it to the unit tests.
On the other hand, our proto is defined as follows, statistics is optional
https://github.com/apache/orc/blob/7d2838b4b38111bc1bfa00592d84a8b36286b9f2/proto/orc_proto.proto#L102-L105
Our orc writer implementation, however, will definitely write statistics, and there is no optional configuration, so it cannot be verified by the files written by orc
https://github.com/apache/orc/blob/7d2838b4b38111bc1bfa00592d84a8b36286b9f2/java/core/src/java/org/apache/orc/impl/writer/TreeWriterBase.java#L322-L330
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun merged pull request #1003: ORC-1082: Improve `FileDump` and `JsonFileDump` to be robust on missing column statistics
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun merged pull request #1003:
URL: https://github.com/apache/orc/pull/1003
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org