You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2022/03/23 12:51:58 UTC
[GitHub] [tinkerpop] FlorianHockmann opened a new pull request #1592: TINKERPOP-2726 Fix boolean translation in Python
FlorianHockmann opened a new pull request #1592:
URL: https://github.com/apache/tinkerpop/pull/1592
https://issues.apache.org/jira/browse/TINKERPOP-2726
This ensures that the GroovyTranslator in Python creates valid boolean values `true` / `false` instead of `True` / `False`.
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] FlorianHockmann commented on pull request #1592: TINKERPOP-2726 Fix boolean translation in Python
Posted by GitBox <gi...@apache.org>.
FlorianHockmann commented on pull request #1592:
URL: https://github.com/apache/tinkerpop/pull/1592#issuecomment-1077591408
> a CHANGELOG entry would be nice
I thought that this only fixes a bug that probably nobody noticed until now and that it's therefore enough to have the automated changelog entry from the JIRA ticket, but I can of course also add an explicit mention.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] FlorianHockmann commented on pull request #1592: TINKERPOP-2726 Fix boolean translation in Python
Posted by GitBox <gi...@apache.org>.
FlorianHockmann commented on pull request #1592:
URL: https://github.com/apache/tinkerpop/pull/1592#issuecomment-1077805349
Added the CHANGELOG entry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] FlorianHockmann merged pull request #1592: TINKERPOP-2726 Fix boolean translation in Python
Posted by GitBox <gi...@apache.org>.
FlorianHockmann merged pull request #1592:
URL: https://github.com/apache/tinkerpop/pull/1592
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] mikepersonick commented on pull request #1592: TINKERPOP-2726 Fix boolean translation in Python
Posted by GitBox <gi...@apache.org>.
mikepersonick commented on pull request #1592:
URL: https://github.com/apache/tinkerpop/pull/1592#issuecomment-1080666555
+1 but again, it worries me that we hadn't already caught this. See my comment on the GroovyTransalator PR. For each of these translators, we should run the whole Gherkin test suite through them and then compare the bytecode for the original and the translated. Or something like that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] FlorianHockmann commented on pull request #1592: TINKERPOP-2726 Fix boolean translation in Python
Posted by GitBox <gi...@apache.org>.
FlorianHockmann commented on pull request #1592:
URL: https://github.com/apache/tinkerpop/pull/1592#issuecomment-1080693208
Using the Gherkin test suite to test the translators definitely sounds good to me. I would probably just execute the scenarios however with the translated code and then compare the results to what is expected in the scenario / feature.
I think not all translations are 1:1 translations. `with()` is for example implemented as `WithStrategy(OptionsStrategy)` in the GLVs which isn't a problem for the translation but it complicates the comparison of just the bytecode.
But we should probably discuss this separately. Do you want to create a ticket for this in JIRA so we don't forget about it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette commented on pull request #1592: TINKERPOP-2726 Fix boolean translation in Python
Posted by GitBox <gi...@apache.org>.
spmallette commented on pull request #1592:
URL: https://github.com/apache/tinkerpop/pull/1592#issuecomment-1077600519
i think manual changelog entries are the better accounting of modifications because they often have better wording than the JIRAs and might also be more detailed in terms of changes. the generated JIRA list is just for reference imo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette commented on pull request #1592: TINKERPOP-2726 Fix boolean translation in Python
Posted by GitBox <gi...@apache.org>.
spmallette commented on pull request #1592:
URL: https://github.com/apache/tinkerpop/pull/1592#issuecomment-1077573026
a CHANGELOG entry would be nice - other than that VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org