You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@paimon.apache.org by "schnappi17 (via GitHub)" <gi...@apache.org> on 2024/03/07 12:06:42 UTC

Re: [PR] [Core]Clean orphan files for branch [incubator-paimon]

schnappi17 commented on code in PR #2863:
URL: https://github.com/apache/incubator-paimon/pull/2863#discussion_r1516047981


##########
paimon-core/src/main/java/org/apache/paimon/utils/SnapshotManager.java:
##########
@@ -253,6 +256,17 @@ public List<Snapshot> safelyGetAllSnapshots() throws IOException {
                         .map(this::snapshotPath)
                         .collect(Collectors.toList());
 

Review Comment:
   Maybe we can enrich the `BranchManager::branches()` to get all the branch set info? You can rebase master to see the implementation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org