You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@rocketmq.apache.org by "Mark Yang (JIRA)" <ji...@apache.org> on 2018/02/12 06:56:00 UTC
[jira] [Commented] (ROCKETMQ-346) the parameter’s name in Message Class’s construction should not be plural
[ https://issues.apache.org/jira/browse/ROCKETMQ-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16360363#comment-16360363 ]
Mark Yang commented on ROCKETMQ-346:
------------------------------------
I’ll submit a pr to remove the “s”
> the parameter’s name in Message Class’s construction should not be plural
> -------------------------------------------------------------------------
>
> Key: ROCKETMQ-346
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-346
> Project: Apache RocketMQ
> Issue Type: Improvement
> Components: rocketmq-commons
> Reporter: Mark Yang
> Assignee: Jixiang Jin
> Priority: Major
>
> public Message(String topic, String tags, byte[] body) {
> this(topic, tags, "", 0, body, true);
> }
> “tags” is plural，but one message could only has one tag，“tags” is confusing
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)