[GitHub] hughhhh closed pull request #4899: Remove remaining slice references

[GitBox <gi...@apache.org>]

hughhhh closed pull request #4899: Remove remaining slice references
URL: https://github.com/apache/incubator-superset/pull/4899
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/superset/assets/src/addSlice/AddSliceContainer.jsx b/superset/assets/src/addSlice/AddSliceContainer.jsx
index 68b5eee250..9b7c4bd413 100644
--- a/superset/assets/src/addSlice/AddSliceContainer.jsx
+++ b/superset/assets/src/addSlice/AddSliceContainer.jsx
@@ -56,7 +56,7 @@ export default class AddSliceContainer extends React.PureComponent {
   render() {
     return (
       <div className="container">
-        <Panel header={<h3>{t('Create a new slice')}</h3>}>
+        <Panel header={<h3>{t('Create a new chart')}</h3>}>
           <div>
             <p>{t('Choose a datasource')}</p>
             <div style={styleSelectWidth}>
diff --git a/superset/assets/src/components/AlteredSliceTag.jsx b/superset/assets/src/components/AlteredSliceTag.jsx
index 5c779651c2..209e4a94bd 100644
--- a/superset/assets/src/components/AlteredSliceTag.jsx
+++ b/superset/assets/src/components/AlteredSliceTag.jsx
@@ -134,7 +134,7 @@ export default class AlteredSliceTag extends React.Component {
       <ModalTrigger
         animation
         triggerNode={this.renderTriggerNode()}
-        modalTitle={t('Slice changes')}
+        modalTitle={t('Chart changes')}
         bsSize="large"
         modalBody={this.renderModalBody()}
       />
diff --git a/superset/assets/src/dashboard/components/SaveModal.jsx b/superset/assets/src/dashboard/components/SaveModal.jsx
index da465a0057..95c9a13ec1 100644
--- a/superset/assets/src/dashboard/components/SaveModal.jsx
+++ b/superset/assets/src/dashboard/components/SaveModal.jsx
@@ -138,7 +138,7 @@ class SaveModal extends React.PureComponent {
                 checked={this.state.duplicateSlices}
                 onChange={this.toggleDuplicateSlices.bind(this)}
               />
-              <span className="m-l-5">also copy (duplicate) slices</span>
+              <span className="m-l-5">also copy (duplicate) charts</span>
             </div>
           </FormGroup>
         }
diff --git a/superset/assets/src/dashboard/components/SliceAdder.jsx b/superset/assets/src/dashboard/components/SliceAdder.jsx
index d5be8caff6..e99d00f339 100644
--- a/superset/assets/src/dashboard/components/SliceAdder.jsx
+++ b/superset/assets/src/dashboard/components/SliceAdder.jsx
@@ -70,7 +70,7 @@ class SliceAdder extends React.Component {
       error: (error) => {
         this.errored = true;
         this.setState({
-          errorMsg: t('Sorry, there was an error fetching slices to this dashboard: ') +
+          errorMsg: t('Sorry, there was an error fetching charts to this dashboard: ') +
           this.getAjaxErrorMsg(error),
         });
       },
@@ -90,7 +90,7 @@ class SliceAdder extends React.Component {
       .fail((error) => {
         adder.errored = true;
         adder.setState({
-          errorMsg: t('Sorry, there was an error adding slices to this dashboard: ') +
+          errorMsg: t('Sorry, there was an error adding charts to this dashboard: ') +
           this.getAjaxErrorMsg(error),
         });
       });
@@ -193,7 +193,7 @@ class SliceAdder extends React.Component {
             onClick={this.addSlices}
             disabled={!enableAddSlice}
           >
-            {t('Add Slices')}
+            {t('Add Charts')}
           </button>
         </div>
       </div>
@@ -202,13 +202,13 @@ class SliceAdder extends React.Component {
     return (
       <ModalTrigger
         triggerNode={this.props.triggerNode}
-        tooltip={t('Add a new slice to the dashboard')}
+        tooltip={t('Add a new chart to the dashboard')}
         beforeOpen={this.onEnterModal.bind(this)}
         isMenuItem
         modalBody={modalContent}
         bsSize="large"
         setModalAsTriggerChildren
-        modalTitle={t('Add Slices to Dashboard')}
+        modalTitle={t('Add Charts to Dashboard')}
       />
     );
   }


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org