[GitHub] [tvm] tqchen commented on a diff in pull request #15169: [Unity][Dlight] general reduction

["tqchen (via GitHub)" <gi...@apache.org>]

tqchen commented on code in PR #15169:
URL: https://github.com/apache/tvm/pull/15169#discussion_r1244548558


##########
src/tir/schedule/analysis/analysis.cc:
##########
@@ -1459,6 +1470,12 @@ bool IsTrivialBinding(const ScheduleState& self, const StmtSRef& block_sref) {
   return true;
 }
 
+TVM_REGISTER_GLOBAL("tir.schedule.IsTrivialBinding").set_body_typed(

Review Comment:
   good to have checks and be robust



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org