You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/15 12:07:53 UTC

[GitHub] [beam] tvalentyn commented on a diff in pull request #21868: Updated documentation for ml.inference docs.

tvalentyn commented on code in PR #21868:
URL: https://github.com/apache/beam/pull/21868#discussion_r897897894


##########
sdks/python/apache_beam/ml/inference/base.py:
##########
@@ -86,24 +83,38 @@ def load_model(self) -> ModelT:
 
   def run_inference(self, batch: Sequence[ExampleT], model: ModelT,
                     **kwargs) -> Iterable[PredictionT]:
-    """Runs inferences on a batch of examples and
-    returns an Iterable of Predictions."""
+    """Runs inferences on a batch of examples.

Review Comment:
   Can we document inputs as well?
   (also, need to resolve conflicts here and update accordingly).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org