You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Andrew Wang (JIRA)" <ji...@apache.org> on 2012/07/24 01:48:34 UTC

[jira] [Created] (HDFS-3711) Manually convert remaining tests to JUnit4

Andrew Wang created HDFS-3711:
---------------------------------

             Summary: Manually convert remaining tests to JUnit4
                 Key: HDFS-3711
                 URL: https://issues.apache.org/jira/browse/HDFS-3711
             Project: Hadoop HDFS
          Issue Type: Improvement
    Affects Versions: 2.0.0-alpha
            Reporter: Andrew Wang
            Assignee: Andrew Wang


In HDFS-3583, we used a fixup script to automatically convert most of the HDFS tests to JUnit4. There are a couple tests left that were too difficult and need to be manually converted (try {{`grep -r "junit.framework" hadoop-hdfs-project}} to see what's left).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-3711) Manually convert remaining tests to JUnit4

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13421511#comment-13421511 ] 

Hudson commented on HDFS-3711:
------------------------------

Integrated in Hadoop-Mapreduce-trunk-Commit #2535 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2535/])
    HDFS-3711. Manually convert remaining tests to JUnit4. Contributed by Andrew Wang. (Revision 1365119)

     Result = FAILURE
atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1365119
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/docs/src/documentation/content/xdocs/faultinject_framework.xml
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDataTransferProtocol.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileConcurrentReader.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCreation.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/protocolPB/TestPBHelper.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestSimulatedFSDataset.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCheckpoint.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeMXBean.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestParallelImageWrite.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/unit/org/apache/hadoop/hdfs/server/namenode/TestNNLeaseRecovery.java

                
> Manually convert remaining tests to JUnit4
> ------------------------------------------
>
>                 Key: HDFS-3711
>                 URL: https://issues.apache.org/jira/browse/HDFS-3711
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 2.0.0-alpha
>            Reporter: Andrew Wang
>            Assignee: Andrew Wang
>             Fix For: 2.2.0-alpha
>
>         Attachments: hdfs-3711.patch
>
>
> In HDFS-3583, we used a fixup script to automatically convert most of the HDFS tests to JUnit4. There are a couple tests left that were too difficult and need to be manually converted (try {{`grep -r "junit.framework" hadoop-hdfs-project}} to see what's left).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-3711) Manually convert remaining tests to JUnit4

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13421187#comment-13421187 ] 

Hadoop QA commented on HDFS-3711:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12537626/hdfs-3711.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 9 new or modified test files.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

                  org.apache.hadoop.hdfs.TestFileAppend4

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2892//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2892//console

This message is automatically generated.
                
> Manually convert remaining tests to JUnit4
> ------------------------------------------
>
>                 Key: HDFS-3711
>                 URL: https://issues.apache.org/jira/browse/HDFS-3711
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 2.0.0-alpha
>            Reporter: Andrew Wang
>            Assignee: Andrew Wang
>         Attachments: hdfs-3711.patch
>
>
> In HDFS-3583, we used a fixup script to automatically convert most of the HDFS tests to JUnit4. There are a couple tests left that were too difficult and need to be manually converted (try {{`grep -r "junit.framework" hadoop-hdfs-project}} to see what's left).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HDFS-3711) Manually convert remaining tests to JUnit4

Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-3711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eli Collins updated HDFS-3711:
------------------------------

    Status: Patch Available  (was: Open)
    
> Manually convert remaining tests to JUnit4
> ------------------------------------------
>
>                 Key: HDFS-3711
>                 URL: https://issues.apache.org/jira/browse/HDFS-3711
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 2.0.0-alpha
>            Reporter: Andrew Wang
>            Assignee: Andrew Wang
>         Attachments: hdfs-3711.patch
>
>
> In HDFS-3583, we used a fixup script to automatically convert most of the HDFS tests to JUnit4. There are a couple tests left that were too difficult and need to be manually converted (try {{`grep -r "junit.framework" hadoop-hdfs-project}} to see what's left).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HDFS-3711) Manually convert remaining tests to JUnit4

Posted by "Aaron T. Myers (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-3711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aaron T. Myers updated HDFS-3711:
---------------------------------

          Resolution: Fixed
       Fix Version/s: 2.2.0-alpha
    Target Version/s: 2.2.0-alpha
        Hadoop Flags: Reviewed
              Status: Resolved  (was: Patch Available)

I've just committed this to trunk and branch-2.

Thanks a lot for the contribution, Andrew, and thanks for the review, Eli.
                
> Manually convert remaining tests to JUnit4
> ------------------------------------------
>
>                 Key: HDFS-3711
>                 URL: https://issues.apache.org/jira/browse/HDFS-3711
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 2.0.0-alpha
>            Reporter: Andrew Wang
>            Assignee: Andrew Wang
>             Fix For: 2.2.0-alpha
>
>         Attachments: hdfs-3711.patch
>
>
> In HDFS-3583, we used a fixup script to automatically convert most of the HDFS tests to JUnit4. There are a couple tests left that were too difficult and need to be manually converted (try {{`grep -r "junit.framework" hadoop-hdfs-project}} to see what's left).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-3711) Manually convert remaining tests to JUnit4

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13421476#comment-13421476 ] 

Hudson commented on HDFS-3711:
------------------------------

Integrated in Hadoop-Hdfs-trunk-Commit #2579 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2579/])
    HDFS-3711. Manually convert remaining tests to JUnit4. Contributed by Andrew Wang. (Revision 1365119)

     Result = SUCCESS
atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1365119
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/docs/src/documentation/content/xdocs/faultinject_framework.xml
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDataTransferProtocol.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileConcurrentReader.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCreation.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/protocolPB/TestPBHelper.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestSimulatedFSDataset.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCheckpoint.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeMXBean.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestParallelImageWrite.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/unit/org/apache/hadoop/hdfs/server/namenode/TestNNLeaseRecovery.java

                
> Manually convert remaining tests to JUnit4
> ------------------------------------------
>
>                 Key: HDFS-3711
>                 URL: https://issues.apache.org/jira/browse/HDFS-3711
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 2.0.0-alpha
>            Reporter: Andrew Wang
>            Assignee: Andrew Wang
>         Attachments: hdfs-3711.patch
>
>
> In HDFS-3583, we used a fixup script to automatically convert most of the HDFS tests to JUnit4. There are a couple tests left that were too difficult and need to be manually converted (try {{`grep -r "junit.framework" hadoop-hdfs-project}} to see what's left).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-3711) Manually convert remaining tests to JUnit4

Posted by "Aaron T. Myers (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13421473#comment-13421473 ] 

Aaron T. Myers commented on HDFS-3711:
--------------------------------------

The test failure is unrelated. TestFileAppend4 is known to be flaky sometimes, and I just ran it locally with and without this patch, and confirmed that it passed just fine.

I'm going to commit this momentarily.
                
> Manually convert remaining tests to JUnit4
> ------------------------------------------
>
>                 Key: HDFS-3711
>                 URL: https://issues.apache.org/jira/browse/HDFS-3711
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 2.0.0-alpha
>            Reporter: Andrew Wang
>            Assignee: Andrew Wang
>         Attachments: hdfs-3711.patch
>
>
> In HDFS-3583, we used a fixup script to automatically convert most of the HDFS tests to JUnit4. There are a couple tests left that were too difficult and need to be manually converted (try {{`grep -r "junit.framework" hadoop-hdfs-project}} to see what's left).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-3711) Manually convert remaining tests to JUnit4

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13422283#comment-13422283 ] 

Hudson commented on HDFS-3711:
------------------------------

Integrated in Hadoop-Mapreduce-trunk #1147 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1147/])
    HDFS-3711. Manually convert remaining tests to JUnit4. Contributed by Andrew Wang. (Revision 1365119)

     Result = FAILURE
atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1365119
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/docs/src/documentation/content/xdocs/faultinject_framework.xml
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDataTransferProtocol.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileConcurrentReader.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCreation.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/protocolPB/TestPBHelper.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestSimulatedFSDataset.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCheckpoint.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeMXBean.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestParallelImageWrite.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/unit/org/apache/hadoop/hdfs/server/namenode/TestNNLeaseRecovery.java

                
> Manually convert remaining tests to JUnit4
> ------------------------------------------
>
>                 Key: HDFS-3711
>                 URL: https://issues.apache.org/jira/browse/HDFS-3711
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 2.0.0-alpha
>            Reporter: Andrew Wang
>            Assignee: Andrew Wang
>             Fix For: 2.2.0-alpha
>
>         Attachments: hdfs-3711.patch
>
>
> In HDFS-3583, we used a fixup script to automatically convert most of the HDFS tests to JUnit4. There are a couple tests left that were too difficult and need to be manually converted (try {{`grep -r "junit.framework" hadoop-hdfs-project}} to see what's left).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-3711) Manually convert remaining tests to JUnit4

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13421479#comment-13421479 ] 

Hudson commented on HDFS-3711:
------------------------------

Integrated in Hadoop-Common-trunk-Commit #2514 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2514/])
    HDFS-3711. Manually convert remaining tests to JUnit4. Contributed by Andrew Wang. (Revision 1365119)

     Result = SUCCESS
atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1365119
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/docs/src/documentation/content/xdocs/faultinject_framework.xml
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDataTransferProtocol.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileConcurrentReader.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCreation.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/protocolPB/TestPBHelper.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestSimulatedFSDataset.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCheckpoint.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeMXBean.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestParallelImageWrite.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/unit/org/apache/hadoop/hdfs/server/namenode/TestNNLeaseRecovery.java

                
> Manually convert remaining tests to JUnit4
> ------------------------------------------
>
>                 Key: HDFS-3711
>                 URL: https://issues.apache.org/jira/browse/HDFS-3711
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 2.0.0-alpha
>            Reporter: Andrew Wang
>            Assignee: Andrew Wang
>             Fix For: 2.2.0-alpha
>
>         Attachments: hdfs-3711.patch
>
>
> In HDFS-3583, we used a fixup script to automatically convert most of the HDFS tests to JUnit4. There are a couple tests left that were too difficult and need to be manually converted (try {{`grep -r "junit.framework" hadoop-hdfs-project}} to see what's left).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HDFS-3711) Manually convert remaining tests to JUnit4

Posted by "Andrew Wang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-3711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Wang updated HDFS-3711:
------------------------------

    Attachment: hdfs-3711.patch

This is the same patch that was in the comments of HDFS-3583, rebased against trunk. Assuming test-patch.sh is happy, I'm happy.
                
> Manually convert remaining tests to JUnit4
> ------------------------------------------
>
>                 Key: HDFS-3711
>                 URL: https://issues.apache.org/jira/browse/HDFS-3711
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 2.0.0-alpha
>            Reporter: Andrew Wang
>            Assignee: Andrew Wang
>         Attachments: hdfs-3711.patch
>
>
> In HDFS-3583, we used a fixup script to automatically convert most of the HDFS tests to JUnit4. There are a couple tests left that were too difficult and need to be manually converted (try {{`grep -r "junit.framework" hadoop-hdfs-project}} to see what's left).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-3711) Manually convert remaining tests to JUnit4

Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13421148#comment-13421148 ] 

Eli Collins commented on HDFS-3711:
-----------------------------------

+1 pending jenkins

Andrew, thank you for the effort to conver all these!

FYI I filed HDFS-3715 for addressing the fact that testFileCreationNamenodeRestart is being ignored. If you saw similar issues in your previous patch feel free to do the same.
                
> Manually convert remaining tests to JUnit4
> ------------------------------------------
>
>                 Key: HDFS-3711
>                 URL: https://issues.apache.org/jira/browse/HDFS-3711
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 2.0.0-alpha
>            Reporter: Andrew Wang
>            Assignee: Andrew Wang
>         Attachments: hdfs-3711.patch
>
>
> In HDFS-3583, we used a fixup script to automatically convert most of the HDFS tests to JUnit4. There are a couple tests left that were too difficult and need to be manually converted (try {{`grep -r "junit.framework" hadoop-hdfs-project}} to see what's left).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-3711) Manually convert remaining tests to JUnit4

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13422208#comment-13422208 ] 

Hudson commented on HDFS-3711:
------------------------------

Integrated in Hadoop-Hdfs-trunk #1115 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1115/])
    HDFS-3711. Manually convert remaining tests to JUnit4. Contributed by Andrew Wang. (Revision 1365119)

     Result = FAILURE
atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1365119
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/docs/src/documentation/content/xdocs/faultinject_framework.xml
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDataTransferProtocol.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileConcurrentReader.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCreation.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/protocolPB/TestPBHelper.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestSimulatedFSDataset.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCheckpoint.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeMXBean.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestParallelImageWrite.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/unit/org/apache/hadoop/hdfs/server/namenode/TestNNLeaseRecovery.java

                
> Manually convert remaining tests to JUnit4
> ------------------------------------------
>
>                 Key: HDFS-3711
>                 URL: https://issues.apache.org/jira/browse/HDFS-3711
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 2.0.0-alpha
>            Reporter: Andrew Wang
>            Assignee: Andrew Wang
>             Fix For: 2.2.0-alpha
>
>         Attachments: hdfs-3711.patch
>
>
> In HDFS-3583, we used a fixup script to automatically convert most of the HDFS tests to JUnit4. There are a couple tests left that were too difficult and need to be manually converted (try {{`grep -r "junit.framework" hadoop-hdfs-project}} to see what's left).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Closed] (HDFS-3711) Manually convert remaining tests to JUnit4

Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-3711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arun C Murthy closed HDFS-3711.
-------------------------------

    
> Manually convert remaining tests to JUnit4
> ------------------------------------------
>
>                 Key: HDFS-3711
>                 URL: https://issues.apache.org/jira/browse/HDFS-3711
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 2.0.0-alpha
>            Reporter: Andrew Wang
>            Assignee: Andrew Wang
>             Fix For: 2.0.2-alpha
>
>         Attachments: hdfs-3711.patch
>
>
> In HDFS-3583, we used a fixup script to automatically convert most of the HDFS tests to JUnit4. There are a couple tests left that were too difficult and need to be manually converted (try {{`grep -r "junit.framework" hadoop-hdfs-project}} to see what's left).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira