You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Uwe Schindler (JIRA)" <ji...@apache.org> on 2010/11/01 00:09:23 UTC

[jira] Updated: (LUCENE-2733) Add private ctors to static utility classes

     [ https://issues.apache.org/jira/browse/LUCENE-2733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Uwe Schindler updated LUCENE-2733:
----------------------------------

    Attachment: LUCENE-2733.patch

Here are some of them, I am sure, there may be more such classes (possibly outside util).

When we backport to 3.x, we should revalidate (some classes existed before, eg. BitUtil), but they are all maked as @lucene.internal, so we may remove the ctors easily.

> Add private ctors to static utility classes
> -------------------------------------------
>
>                 Key: LUCENE-2733
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2733
>             Project: Lucene - Java
>          Issue Type: Task
>            Reporter: Uwe Schindler
>            Priority: Minor
>             Fix For: 3.1, 4.0
>
>         Attachments: LUCENE-2733.patch
>
>
> During development in 3.x and trunk we added some new classes like IOUtils and CodecUtils that are only providing static methods, but have no ctor at all. This adds the default empty public ctor, which is wrong, the classes should never be instantiated.
> We should add private dummy ctors to prevent creating instances.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org