You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/01 16:13:22 UTC

[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #4050: single_distinct_to_groupby no longer drops qualifiers

alamb commented on code in PR #4050:
URL: https://github.com/apache/arrow-datafusion/pull/4050#discussion_r1010620006


##########
datafusion/core/tests/sql/group_by.rs:
##########
@@ -654,13 +654,13 @@ async fn group_by_dictionary() {
         .expect("ran plan correctly");
 
         let expected = vec![
-            "+-----+------------------------+",
-            "| val | COUNT(DISTINCT t.dict) |",
-            "+-----+------------------------+",
-            "| 1   | 2                      |",
-            "| 2   | 2                      |",
-            "| 4   | 1                      |",
-            "+-----+------------------------+",
+            "+-------+------------------------+",

Review Comment:
   I don't understand why this plan would produce `t.val` as the column name but the query above it (`SELECT val, count(distinct dict) FROM t GROUP BY val`) still produced `val` 🤔 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org